Remove type argument from HasChildren

mwilliamson · mwilliamson · commit 2b5635c1425f · 2025-08-03T09:36:04.000+01:00
diff --git a/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java b/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java
@@ -81,22 +81,6 @@ private DocumentToHtml(DocumentToHtmlOptions options, List<Comment> comments) {
         this.comments = Maps.toMapWithKey(comments, Comment::getCommentId);
     }
 
-    private List<HtmlNode> convertToHtml(Document document, Context context) {
-        List<HtmlNode> mainBody = convertChildrenToHtml(document, context);
-        // TODO: can you have note references inside a note?
-        List<Note> notes = findNotes(document, noteReferences);
-
-        List<HtmlNode> noteNodes = notes.isEmpty()
-            ? list()
-            : list(Html.element("ol", eagerMap(notes, note -> convertToHtml(note, context))));
-
-        List<HtmlNode> commentNodes = referencedComments.isEmpty()
-            ? list()
-            : list(Html.element("dl", eagerFlatMap(referencedComments, comment -> convertToHtml(comment, context))));
-
-        return eagerConcat(mainBody, noteNodes, commentNodes);
-    }
-
     private HtmlNode convertToHtml(Note note, Context context) {
         String id = generateNoteHtmlId(note.getNoteType(), note.getId());
         String referenceId = generateNoteRefHtmlId(note.getNoteType(), note.getId());
@@ -135,11 +119,28 @@ private List<HtmlNode> convertToHtml(List<DocumentElement> elements, Context con
         );
     }
 
-    private <T> List<HtmlNode> convertChildrenToHtml(HasChildren<T> element, Context context) {
+    private <T> List<HtmlNode> convertChildrenToHtml(HasChildren element, Context context) {
         return convertToHtml(element.getChildren(), context);
     }
 
     private class ElementConverterVisitor implements DocumentElementVisitor<List<HtmlNode>, Context> {
+        @Override
+        public List<HtmlNode> visit(Document document, Context context) {
+            List<HtmlNode> mainBody = convertChildrenToHtml(document, context);
+            // TODO: can you have note references inside a note?
+            List<Note> notes = findNotes(document, noteReferences);
+
+            List<HtmlNode> noteNodes = notes.isEmpty()
+                ? list()
+                : list(Html.element("ol", eagerMap(notes, note -> convertToHtml(note, context))));
+
+            List<HtmlNode> commentNodes = referencedComments.isEmpty()
+                ? list()
+                : list(Html.element("dl", eagerFlatMap(referencedComments, comment -> convertToHtml(comment, context))));
+
+            return eagerConcat(mainBody, noteNodes, commentNodes);
+        }
+
         @Override
         public List<HtmlNode> visit(Paragraph paragraph, Context context) {
             Supplier<List<HtmlNode>> children = () -> {
diff --git a/src/main/java/org/zwobble/mammoth/internal/conversion/RawText.java b/src/main/java/org/zwobble/mammoth/internal/conversion/RawText.java
@@ -13,7 +13,7 @@ public static String extractRawText(Document document) {
         return extractRawTextOfChildren(document);
     }
 
-    private static <T> String extractRawTextOfChildren(HasChildren<T> parent) {
+    private static String extractRawTextOfChildren(HasChildren parent) {
         return extractRawText(parent.getChildren());
     }
 
@@ -27,8 +27,8 @@ public static String extractRawText(DocumentElement node) {
         } else if (node instanceof Tab) {
             return "\t";
         } else {
-            List<DocumentElement> children = tryCast(HasGetChildren.class, node)
-                .map(HasGetChildren::getChildren)
+            List<DocumentElement> children = tryCast(HasChildren.class, node)
+                .map(HasChildren::getChildren)
                 .orElse(list());
             String suffix = tryCast(Paragraph.class, node).map(paragraph -> "\n\n").orElse("");
             return extractRawText(children) + suffix;
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/Document.java b/src/main/java/org/zwobble/mammoth/internal/documents/Document.java
@@ -2,7 +2,7 @@
 
 import java.util.List;
 
-public class Document implements HasChildren<Document> {
+public class Document implements DocumentElement, HasChildren {
     private final List<DocumentElement> children;
     private final Notes notes;
     private final List<Comment> comments;
@@ -19,10 +19,15 @@ public List<DocumentElement> getChildren() {
     }
 
     @Override
-    public Document replaceChildren(List<DocumentElement> newChildren) {
+    public DocumentElement replaceChildren(List<DocumentElement> newChildren) {
         return new Document(newChildren, this.notes, this.comments);
     }
 
+    @Override
+    public <T, U> T accept(DocumentElementVisitor<T, U> visitor, U context) {
+        return visitor.visit(this, context);
+    }
+
     public Notes getNotes() {
         return notes;
     }
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/DocumentElementVisitor.java b/src/main/java/org/zwobble/mammoth/internal/documents/DocumentElementVisitor.java
@@ -1,6 +1,8 @@
 package org.zwobble.mammoth.internal.documents;
 
 public interface DocumentElementVisitor<T, U> {
+    T visit(Document document, U context);
+
     T visit(Paragraph paragraph, U context);
     T visit(Run run, U context);
     T visit(Text text, U context);
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/HasChildren.java b/src/main/java/org/zwobble/mammoth/internal/documents/HasChildren.java
@@ -2,6 +2,7 @@
 
 import java.util.List;
 
-public interface HasChildren<T> extends HasGetChildren {
-    T replaceChildren(List<DocumentElement> newChildren);
+public interface HasChildren {
+    List<DocumentElement> getChildren();
+    DocumentElement replaceChildren(List<DocumentElement> newChildren);
 }
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/HasGetChildren.java b/src/main/java/org/zwobble/mammoth/internal/documents/HasGetChildren.java
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/Hyperlink.java b/src/main/java/org/zwobble/mammoth/internal/documents/Hyperlink.java
@@ -3,7 +3,7 @@
 import java.util.List;
 import java.util.Optional;
 
-public class Hyperlink implements DocumentElement, HasChildren<Hyperlink> {
+public class Hyperlink implements DocumentElement, HasChildren {
     public static Hyperlink href(String href, Optional<String> targetFrame, List<DocumentElement> children) {
         return new Hyperlink(Optional.of(href), Optional.empty(), targetFrame, children);
     }
@@ -42,7 +42,7 @@ public List<DocumentElement> getChildren() {
     }
 
     @Override
-    public Hyperlink replaceChildren(List<DocumentElement> newChildren) {
+    public DocumentElement replaceChildren(List<DocumentElement> newChildren) {
         return new Hyperlink(this.href, this.anchor, this.targetFrame, newChildren);
     }
 
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/Paragraph.java b/src/main/java/org/zwobble/mammoth/internal/documents/Paragraph.java
@@ -3,7 +3,7 @@
 import java.util.List;
 import java.util.Optional;
 
-public class Paragraph implements DocumentElement, HasChildren<Paragraph> {
+public class Paragraph implements DocumentElement, HasChildren {
     private final Optional<Style> style;
     private final Optional<NumberingLevel> numbering;
     private final ParagraphIndent indent;
@@ -39,7 +39,7 @@ public List<DocumentElement> getChildren() {
     }
 
     @Override
-    public Paragraph replaceChildren(List<DocumentElement> newChildren) {
+    public DocumentElement replaceChildren(List<DocumentElement> newChildren) {
         return new Paragraph(this.style, this.numbering, this.indent, newChildren);
     }
 
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/Run.java b/src/main/java/org/zwobble/mammoth/internal/documents/Run.java
@@ -3,7 +3,7 @@
 import java.util.List;
 import java.util.Optional;
 
-public class Run implements DocumentElement, HasChildren<Run> {
+public class Run implements DocumentElement, HasChildren {
     private final Optional<String> highlight;
     private final boolean isBold;
     private final boolean isItalic;
@@ -81,7 +81,7 @@ public List<DocumentElement> getChildren() {
     }
 
     @Override
-    public Run replaceChildren(List<DocumentElement> newChildren) {
+    public DocumentElement replaceChildren(List<DocumentElement> newChildren) {
         return new Run(
             this.highlight,
             this.isBold,
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/Table.java b/src/main/java/org/zwobble/mammoth/internal/documents/Table.java
@@ -3,7 +3,7 @@
 import java.util.List;
 import java.util.Optional;
 
-public class Table implements DocumentElement, HasChildren<Table> {
+public class Table implements DocumentElement, HasChildren {
     private final Optional<Style> style;
     private final List<DocumentElement> children;
 
@@ -22,7 +22,7 @@ public List<DocumentElement> getChildren() {
     }
 
     @Override
-    public Table replaceChildren(List<DocumentElement> newChildren) {
+    public DocumentElement replaceChildren(List<DocumentElement> newChildren) {
         return new Table(this.style, newChildren);
     }
 
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/TableCell.java b/src/main/java/org/zwobble/mammoth/internal/documents/TableCell.java
@@ -2,7 +2,7 @@
 
 import java.util.List;
 
-public class TableCell implements DocumentElement, HasChildren<TableCell> {
+public class TableCell implements DocumentElement, HasChildren {
     private final int rowspan;
     private final int colspan;
     private final List<DocumentElement> children;
@@ -27,7 +27,7 @@ public List<DocumentElement> getChildren() {
     }
 
     @Override
-    public TableCell replaceChildren(List<DocumentElement> newChildren) {
+    public DocumentElement replaceChildren(List<DocumentElement> newChildren) {
         return new TableCell(this.rowspan, this.colspan, newChildren);
     }
 
diff --git a/src/main/java/org/zwobble/mammoth/internal/documents/TableRow.java b/src/main/java/org/zwobble/mammoth/internal/documents/TableRow.java
@@ -2,7 +2,7 @@
 
 import java.util.List;
 
-public class TableRow implements DocumentElement, HasChildren<TableRow> {
+public class TableRow implements DocumentElement, HasChildren {
     private final List<DocumentElement> children;
     private final boolean isHeader;
 
@@ -17,7 +17,7 @@ public List<DocumentElement> getChildren() {
     }
 
     @Override
-    public TableRow replaceChildren(List<DocumentElement> newChildren) {
+    public DocumentElement replaceChildren(List<DocumentElement> newChildren) {
         return new TableRow(newChildren, this.isHeader);
     }
 
diff --git a/src/main/java/org/zwobble/mammoth/internal/docx/StatefulBodyXmlReader.java b/src/main/java/org/zwobble/mammoth/internal/docx/StatefulBodyXmlReader.java
@@ -591,7 +591,7 @@ private boolean readVmerge(XmlElementLike properties) {
             .orElse(false);
     }
 
-    private static class UnmergedTableCell implements DocumentElement, HasChildren<UnmergedTableCell> {
+    private static class UnmergedTableCell implements DocumentElement, HasChildren {
         private final boolean vmerge;
         private final int colspan;
         private final List<DocumentElement> children;
@@ -608,7 +608,7 @@ public List<DocumentElement> getChildren() {
         }
 
         @Override
-        public UnmergedTableCell replaceChildren(List<DocumentElement> newChildren) {
+        public DocumentElement replaceChildren(List<DocumentElement> newChildren) {
             return new UnmergedTableCell(this.vmerge, this.colspan, newChildren);
         }
 
@@ -771,8 +771,8 @@ private <T extends DocumentElement> Function<DocumentElement, DocumentElement> t
     ) {
         return element -> {
             if (element instanceof HasChildren) {
-                element = ((HasChildren<DocumentElement>) element).replaceChildren(
-                    Lists.eagerMap(((HasGetChildren) element).getChildren(), transformElementsOfType(elementClass, transform))
+                element = ((HasChildren) element).replaceChildren(
+                    Lists.eagerMap(((HasChildren) element).getChildren(), transformElementsOfType(elementClass, transform))
                 );
             }
 

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`import java.util.List;`
`4`	`4`
`5`		`-public interface HasChildren<T> extends HasGetChildren {`
`6`		`- T replaceChildren(List<DocumentElement> newChildren);`
	`5`	`+public interface HasChildren {`
	`6`	`+ List<DocumentElement> getChildren();`
	`7`	`+ DocumentElement replaceChildren(List<DocumentElement> newChildren);`
`7`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`import java.util.List;`
`4`	`4`	`import java.util.Optional;`
`5`	`5`
`6`		`-public class Hyperlink implements DocumentElement, HasChildren<Hyperlink> {`
	`6`	`+public class Hyperlink implements DocumentElement, HasChildren {`
`7`	`7`	`public static Hyperlink href(String href, Optional<String> targetFrame, List<DocumentElement> children) {`
`8`	`8`	`return new Hyperlink(Optional.of(href), Optional.empty(), targetFrame, children);`
`9`	`9`	`}`
`@@ -42,7 +42,7 @@ public List<DocumentElement> getChildren() {`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`@Override`
`45`		`- public Hyperlink replaceChildren(List<DocumentElement> newChildren) {`
	`45`	`+ public DocumentElement replaceChildren(List<DocumentElement> newChildren) {`
`46`	`46`	`return new Hyperlink(this.href, this.anchor, this.targetFrame, newChildren);`
`47`	`47`	`}`
`48`	`48`