Releases in lockstep

[cstamas]

Seems we will need to do this, but there is a problem: I had to remove v prefixes from version as it caused issues:

Caused by: java.lang.IllegalArgumentException: error: bad value for --module-version option: 'v1.3.0-SNAPSHOT'
    at com.sun.tools.javac.main.Arguments.error (Arguments.java:902)
    at com.sun.tools.javac.main.Arguments.doProcessArgs (Arguments.java:384)
    at com.sun.tools.javac.main.Arguments.processArgs (Arguments.java:348)
    at com.sun.tools.javac.main.Arguments.init (Arguments.java:247)
    at com.sun.tools.javac.api.JavacTool.getTask (JavacTool.java:191)
    at com.sun.tools.javac.api.JavacTool.getTask (JavacTool.java:119)
    at com.sun.tools.javac.api.JavacTool.getTask (JavacTool.java:68)
    at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess (JavaxToolsCompiler.java:125)

[cstamas]

@ianopolous

[cstamas]

Seems versions with leading v violate JPMS "module version" spec?
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/module/ModuleDescriptor.java#L957-L1003

[cstamas]

Why was this v prefix added to versions in the first place? I mean, it seems constant and does not add (nor take) anything from selectivity or ordering... but sadly JPMS dislikes it.

[cstamas]

Also, my feeling is that all these tiny projects would benefit a lot from some common parent POM (as they are basically 100% same thing sans dependencies).

Where could be craft one for them? But I personally think pushing them all together into one reactor would really be the simplest...

[ianopolous]

It was just a convention from protocol labs ecosystem. Fine to remove it

[cstamas]

Ok, the v prefix will be removed (clashes with javac --module-version option as can be seen above.

Then we need 1.3.0 release of java-multibase from master, I guess? What are plans, where to publish? jitpack as before or Central?

[ianopolous]

I've pushed 1.3.0 and triggered jitpack

[cstamas]

multiformats/java-multihash#54 read for review and possible merge, to be followed by git-blame ignore...

[cstamas]

last PR for multihash multiformats/java-multihash#55 and I suggest multiformats/java-multihash#52 as well, and then release 1.3.7 (or 1.4.0? I don't know what changes are)

[ianopolous]

multihash 1.4.0 is out now

[cstamas]

next ipld/java-cid#45

[cstamas]

ipld/java-cid#46 is last and a release, 1.4.0?

[ianopolous]

I just noticed cid has the same name issue

[ianopolous]

and multihash too