Skip to content

Commit b087eb7

Browse files
committed
Mark build Java-version guard as fixed in preexisting-issues.md
1 parent 43f92f1 commit b087eb7

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

plans/preexisting-issues.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,11 @@ calling `super.close()` (which would unconditionally close the underlying stream
1616

1717
Fixed: `snapshot()` now delegates to `copy()`, and `rebuild()` is implemented via `MessagePackFactoryBuilder`.
1818

19-
### 3. Build: `msgpack-jackson3` fails to compile locally on Java < 17
19+
### 3. Build: `msgpack-jackson3` fails to compile locally on Java < 17 — FIXED
2020

21-
`msgpack-jackson3` is in the root aggregate unconditionally. The CI works around
22-
this with a bash version check, but a developer running `./sbt test` locally on
23-
Java 8 or 11 gets a hard compilation failure. A cleaner build-level solution
24-
(conditional aggregate, toolchain support, or a separate profile) is needed.
21+
`build.sbt` conditionally includes `msgpack-jackson3` in the root aggregate only when
22+
running on Java 17+. Developers on older JDKs and CI on older JDK matrix entries
23+
skip the module cleanly.
2524

2625
### 4. `MessagePackGenerator.streamWriteContext()` returns null — FIXED
2726

0 commit comments

Comments
 (0)