Fix bugs in msgpack-jackson3

- MessagePackParser.unpackString: use UTF-8 for short strings (<=64 bytes)
  to match the long-string path; platform default charset was used before
- MessagePackGenerator.writeNumber(String): try BigInteger before Double
  to avoid precision loss for large integer strings
- MessagePackGenerator.writeString(Reader, int): handle len=-1 (unknown
  length) by reading until EOF instead of throwing NegativeArraySizeException

Author: komamitsu

msgpack-jackson3/src/main/java/org/msgpack/jackson/dataformat/MessagePackGenerator.java

@@ -598,16 +598,29 @@ public JsonGenerator writeString(char[] text, int offset, int len) throws Jackso
     public JsonGenerator writeString(Reader reader, int len) throws JacksonException
     {
         try {
-            char[] buf = new char[len];
-            int totalRead = 0;
-            while (totalRead < len) {
-                int read = reader.read(buf, totalRead, len - totalRead);
-                if (read < 0) {
-                    break;
+            if (len < 0) {
+                StringBuilder sb = new StringBuilder();
+                char[] tmpBuf = new char[1024];
+                int read;
+                while ((read = reader.read(tmpBuf)) >= 0) {
+                    sb.append(tmpBuf, 0, read);
                 }
-                totalRead += read;
+                char[] chars = new char[sb.length()];
+                sb.getChars(0, chars.length, chars, 0);
+                writeCharArrayTextValue(chars, 0, chars.length);
+            }
+            else {
+                char[] buf = new char[len];
+                int totalRead = 0;
+                while (totalRead < len) {
+                    int read = reader.read(buf, totalRead, len - totalRead);
+                    if (read < 0) {
+                        break;
+                    }
+                    totalRead += read;
+                }
+                writeCharArrayTextValue(buf, 0, totalRead);
             }
-            writeCharArrayTextValue(buf, 0, totalRead);
         }
         catch (IOException e) {
             throw _wrapIOFailure(e);
@@ -797,16 +810,16 @@ public JsonGenerator writeNumber(String encodedValue) throws JacksonException
             }
 
             try {
-                double d = Double.parseDouble(encodedValue);
-                addValueNode(d);
+                BigInteger bi = new BigInteger(encodedValue);
+                addValueNode(bi);
                 return this;
             }
             catch (NumberFormatException ignored) {
             }
 
             try {
-                BigInteger bi = new BigInteger(encodedValue);
-                addValueNode(bi);
+                double d = Double.parseDouble(encodedValue);
+                addValueNode(d);
                 return this;
             }
             catch (NumberFormatException ignored) {

msgpack-jackson3/src/main/java/org/msgpack/jackson/dataformat/MessagePackParser.java

@@ -143,7 +143,7 @@ private String unpackString(MessageUnpacker messageUnpacker) throws IOException
         int strLen = messageUnpacker.unpackRawStringHeader();
         if (strLen <= tempBytes.length) {
             messageUnpacker.readPayload(tempBytes, 0, strLen);
-            return new String(tempBytes, 0, strLen);
+            return new String(tempBytes, 0, strLen, StandardCharsets.UTF_8);
         }
         else {
             byte[] bytes = messageUnpacker.readPayload(strLen);

msgpack-jackson3/src/test/java/org/msgpack/jackson/dataformat/MessagePackGeneratorTest.java

@@ -881,8 +881,8 @@ public void serializeStringAsBigDecimal()
 
         BigDecimal bd = BigDecimal.valueOf(Long.MAX_VALUE).add(BigDecimal.ONE);
         assertThat(
-            MessagePack.newDefaultUnpacker(objectMapper.writeValueAsBytes(bd)).unpackDouble(),
-                is(bd.doubleValue()));
+            MessagePack.newDefaultUnpacker(objectMapper.writeValueAsBytes(bd)).unpackBigInteger(),
+                is(bd.toBigIntegerExact()));
     }
 
     public static class BigIntegerSerializerStoringAsString
@@ -906,8 +906,8 @@ public void serializeStringAsBigInteger()
 
         BigInteger bi = BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.ONE);
         assertThat(
-            MessagePack.newDefaultUnpacker(objectMapper.writeValueAsBytes(bi)).unpackDouble(),
-                is(bi.doubleValue()));
+            MessagePack.newDefaultUnpacker(objectMapper.writeValueAsBytes(bi)).unpackBigInteger(),
+                is(bi));
     }
 
     @Test