Skip to content

Commit 3f0bef4

Browse files
committed
Fix two issues flagged in third AI code review
- MessagePackFactoryBuilder: deep-copy extTypeCustomDesers via copy constructor so rebuilt factories have independent deserializer state - MessagePackDataformatForFieldIdTest: fix typo in test method name (testMixedKeysBackwardsCompatiable -> testMixedKeysBackwardsCompatible)
1 parent b3ce77e commit 3f0bef4

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

msgpack-jackson3/src/main/java/org/msgpack/jackson/dataformat/MessagePackFactoryBuilder.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ public MessagePackFactoryBuilder(MessagePackFactory base)
4747
this.reuseResourceInGenerator = base.isReuseResourceInGenerator();
4848
this.reuseResourceInParser = base.isReuseResourceInParser();
4949
this.supportIntegerKeys = base.isSupportIntegerKeys();
50-
this.extTypeCustomDesers = base.getExtTypeCustomDesers();
50+
ExtensionTypeCustomDeserializers srcDesers = base.getExtTypeCustomDesers();
51+
this.extTypeCustomDesers = srcDesers == null ? null : new ExtensionTypeCustomDeserializers(srcDesers);
5152
}
5253

5354
public MessagePackFactoryBuilder packerConfig(MessagePack.PackerConfig config)

msgpack-jackson3/src/test/java/org/msgpack/jackson/dataformat/MessagePackDataformatForFieldIdTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public void testMixedKeys()
110110
}
111111

112112
@Test
113-
public void testMixedKeysBackwardsCompatiable()
113+
public void testMixedKeysBackwardsCompatible()
114114
throws IOException
115115
{
116116
ObjectMapper mapper = MessagePackMapper.builder(new MessagePackFactory())

0 commit comments

Comments
 (0)