Clean up dead code and add OSGi import exclusions for msgpack-jackson3

- Remove JavaInfo.java: STRING_VALUE_FIELD_IS_CHARS is always false on Java 17+
  since String.value is byte[], not char[]; simplify parser and generator accordingly
- Remove dead writeCharArrayTextKey method and tempChars field
- Add OsgiKeys.importPackage exclusions for android.os and sun.* packages
- Add comments on (int) cast overflow risk in currentTokenLocation/currentLocation

Author: komamitsu

build.sbt

@@ -180,6 +180,7 @@ lazy val msgpackJackson3 = Project(id = "msgpack-jackson3", base = file("msgpack
     description                 := "Jackson 3.x extension that adds support for MessagePack",
     OsgiKeys.bundleSymbolicName := "org.msgpack.msgpack-jackson3",
     OsgiKeys.exportPackage      := Seq("org.msgpack.jackson", "org.msgpack.jackson.dataformat"),
+    OsgiKeys.importPackage      := Seq("!android.os", "!sun.*"),
     Test / fork    := true,
     javacOptions   := Seq("-source", "17", "-target", "17"),
     doc / javacOptions := Seq("-source", "17", "-Xdoclint:none"),

msgpack-jackson3/src/main/java/org/msgpack/jackson/dataformat/JavaInfo.java

@@ -44,8 +44,6 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import static org.msgpack.jackson.dataformat.JavaInfo.STRING_VALUE_FIELD_IS_CHARS;
-
 public class MessagePackGenerator
         extends GeneratorBase
 {
@@ -513,16 +511,6 @@ private boolean areAllAsciiBytes(byte[] bytes, int offset, int len)
         return true;
     }
 
-    private void writeCharArrayTextKey(char[] text, int offset, int len)
-    {
-        byte[] bytes = getBytesIfAscii(text, offset, len);
-        if (bytes != null) {
-            addKeyNode(new AsciiCharString(bytes));
-            return;
-        }
-        addKeyNode(new String(text, offset, len));
-    }
-
     private void writeCharArrayTextValue(char[] text, int offset, int len) throws IOException
     {
         byte[] bytes = getBytesIfAscii(text, offset, len);
@@ -563,13 +551,7 @@ public JacksonFeatureSet<StreamWriteCapability> streamWriteCapabilities()
     @Override
     public JsonGenerator writeName(String name) throws JacksonException
     {
-        if (STRING_VALUE_FIELD_IS_CHARS.get()) {
-            char[] chars = name.toCharArray();
-            writeCharArrayTextKey(chars, 0, chars.length);
-        }
-        else {
-            addKeyNode(name);
-        }
+        addKeyNode(name);
         return this;
     }
 
@@ -592,13 +574,7 @@ else if (name instanceof MessagePackSerializedString) {
     public JsonGenerator writeString(String text) throws JacksonException
     {
         try {
-            if (STRING_VALUE_FIELD_IS_CHARS.get()) {
-                char[] chars = text.toCharArray();
-                writeCharArrayTextValue(chars, 0, chars.length);
-            }
-            else {
-                addValueNode(text);
-            }
+            addValueNode(text);
         }
         catch (IOException e) {
             throw _wrapIOFailure(e);
@@ -673,13 +649,7 @@ public JsonGenerator writeUTF8String(byte[] text, int offset, int length) throws
     public JsonGenerator writeRaw(String text) throws JacksonException
     {
         try {
-            if (STRING_VALUE_FIELD_IS_CHARS.get()) {
-                char[] chars = text.toCharArray();
-                writeCharArrayTextValue(chars, 0, chars.length);
-            }
-            else {
-                addValueNode(text);
-            }
+            addValueNode(text);
         }
         catch (IOException e) {
             throw _wrapIOFailure(e);

msgpack-jackson3/src/main/java/org/msgpack/jackson/dataformat/MessagePackGenerator.java

@@ -42,8 +42,6 @@
 import java.math.BigInteger;
 import java.nio.charset.StandardCharsets;
 
-import static org.msgpack.jackson.dataformat.JavaInfo.STRING_VALUE_FIELD_IS_CHARS;
-
 public class MessagePackParser
         extends ParserMinimalBase
 {
@@ -61,7 +59,6 @@ public class MessagePackParser
     private final IOContext ioContext;
     private ExtensionTypeCustomDeserializers extTypeCustomDesers;
     private final byte[] tempBytes = new byte[64];
-    private final char[] tempChars = new char[64];
 
     private enum Type
     {
@@ -146,19 +143,7 @@ private String unpackString(MessageUnpacker messageUnpacker) throws IOException
         int strLen = messageUnpacker.unpackRawStringHeader();
         if (strLen <= tempBytes.length) {
             messageUnpacker.readPayload(tempBytes, 0, strLen);
-            if (STRING_VALUE_FIELD_IS_CHARS.get()) {
-                for (int i = 0; i < strLen; i++) {
-                    byte b = tempBytes[i];
-                    if ((0x80 & b) != 0) {
-                        return new String(tempBytes, 0, strLen, StandardCharsets.UTF_8);
-                    }
-                    tempChars[i] = (char) b;
-                }
-                return new String(tempChars, 0, strLen);
-            }
-            else {
-                return new String(tempBytes, 0, strLen);
-            }
+            return new String(tempBytes, 0, strLen);
         }
         else {
             byte[] bytes = messageUnpacker.readPayload(strLen);
@@ -604,12 +589,14 @@ public TokenStreamContext streamReadContext()
     @Override
     public TokenStreamLocation currentTokenLocation()
     {
+        // columnNr repurposed as byte offset; truncates for inputs > 2 GB
         return new TokenStreamLocation(ioContext.contentReference(), tokenPosition, -1, (int) tokenPosition);
     }
 
     @Override
     public TokenStreamLocation currentLocation()
     {
+        // columnNr repurposed as byte offset; truncates for inputs > 2 GB
         return new TokenStreamLocation(ioContext.contentReference(), currentPosition, -1, (int) currentPosition);
     }