Skip to content

Commit d7d602e

Browse files
committed
https-dns-proxy: ignore disabled dnsmasq DNS port
1 parent 902e42c commit d7d602e

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

files/etc/init.d/https-dns-proxy

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,8 @@ dnsmasq_instance_append_force_dns_port() {
461461
local cfg="$1" instance_port
462462
[ "$(uci_get 'dhcp' "$cfg")" = "dnsmasq" ] || return 1
463463
config_get instance_port "$cfg" 'port' '53'
464-
str_contains_word "$force_dns_port" "$instance_port" || force_dns_port="${force_dns_port:+${force_dns_port} }${instance_port}"
464+
[ "$instance_port" = "0" ] && return 0
465+
str_contains_word "$force_dns_port" "$instance_port" || force_dns_port="${force_dns_port:+${force_dns_port} }${instance_port}"
465466
}
466467

467468
dnsmasq_doh_server() {

tests/run_tests.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,11 @@ force_dns_port="53 853"
505505
dnsmasq_instance_append_force_dns_port "cfg01"
506506
assert_eq "append_force_dns_port: already present port 53 not duplicated" "53 853" "$force_dns_port"
507507

508+
uci_set "dhcp" "cfg03" ".type" "dnsmasq"
509+
uci_set "dhcp" "cfg03" "port" "0"
510+
dnsmasq_instance_append_force_dns_port "cfg03"
511+
assert_eq "append_force_dns_port: disabled dnsmasq port 0 ignored" "53 853" "$force_dns_port"
512+
508513
uci_set "dhcp" "cfg02" ".type" "dnsmasq"
509514
uci_set "dhcp" "cfg02" "port" "5353"
510515
dnsmasq_instance_append_force_dns_port "cfg02"

0 commit comments

Comments
 (0)