getsockname() breakage? AMD64_LINUX

[dragisha]

I am trying to support some of my old code and along the way, I upgraded my system to d5.11.9

At the moment when my code invokes getsockname();

PROCEDURE getsockname (fd: INTEGER): IP.Endpoint =
  TYPE
    Addr = Uin.struct_sockaddr_in;
  VAR
    addr: Addr;
    endpoint: IP.Endpoint;
    len: Usocket.socklen_t := BYTESIZE (addr);
  BEGIN
    IF Usocket.getsockname (fd, ADR (addr), ADR (len)) >= 0 THEN

I get this:

../src/unix/Common/Usocket.c:253: SockAddrNativeToM3: Assertion family == AF_INET || family == AF_INET6 || family == AF_UNIX' failed.`

Usocket.c code:

static
int
SockAddrNativeToM3(const NativeSockAddrUnionAll* native, M3SockAddrUnionAll* m3)
{
    const unsigned family = native->in.sin_family;
#ifdef AF_UNIX
    printf("in.sin_family=%d\n", family);     
    assert(family == AF_INET || family == AF_INET6 || family == AF_UNIX);

family value is zero at this point.

Does this ring a bell to someone? What changed and what do I have to adjust to make this work?

TIA,
dragisha

[dragisha]

It's not so compatible with older code after all.

I will try to retrace this. I would also really appreciate hearing if anybody is using this latest & greatest version with simple TCP listener code.

commit 0584b288f5d083705371da01813d1249f80b27bc
Author: JayKrell <jay.krell@cornell.edu>
Date:   Tue Mar 16 21:51:24 2021 -0700

    m3core: Change Usocket to copy sockaddr in or out.
    Handle AF_INET, AF_INET6, and ifdef AF_UNIX.
    This should enable reverting related recent work,
    and get much after than that work, providing
    source compatibility to existing code while meeting
    the goals of converging platforms. Just at the slight cost
    of gnarly code (gnarly either way) and slight copying cost.

[dragisha]

Back to d5.10.0, everything works.

[VictorMiasnikov]

d5.11.9 -- is unfortunately non informative

This is affected
https://github.com/VictorMiasnikov/cm3/releases/tag/d5.11.9-ZZYYXX-20241118_21-50
?

[dragisha]

Will check at some point. I fixed my problem now but will get back to it soon.

More information is - I was building it from the current master, as of a few days ago.

[VictorMiasnikov]

It set half-hidden. I will delete this msg

( Possible offtopic -- please see one old Issue related grammar of M3, or see L i n k e d I n , or send smb to vvm (at) tut.by

Thank! )

[dragisha]

You lost me on gammar :), and what is smb? :)

[VictorMiasnikov]

It set half-hidden. I will delete this msg

r added...
smb -- somebody

[VictorMiasnikov]

( To All: I will delete offtopic messages later)
It set half-hidden. I will delete this msg

Battery is low --I switched to smartphone...

( To All: I will delete offtopic messages later)

[jaykrell]

assert(family == AF_INET || family == AF_INET6 || family == AF_UNIX);

change to add || family == 0
?

[demoitem]

There was a small bug in Usocket.c The len param was not being initialised. Should be fixed now.

[VictorMiasnikov]

There was a small bug in Usocket.c The len param was not being initialised. Should be fixed now.

We have Non-good news:

8_I386_NT _ build (c).txt
5_I386_NT _ build (integrated).txt


...
2025-08-15T15:02:39.5953189Z new source -> compiling Usocket.c
2025-08-15T15:02:39.5953372Z Usocket.c
2025-08-15T15:02:39.5953766Z ../src\\unix\\Common/Usocket.c(471): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion
2025-08-15T15:02:39.5954449Z ../src\\unix\\Common/Usocket.c(481): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion
2025-08-15T15:02:39.5955104Z ../src\\unix\\Common/Usocket.c(491): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion
2025-08-15T15:02:39.5955755Z ../src\\unix\\Common/Usocket.c(546): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion
2025-08-15T15:02:39.5956175Z   compile_c => 2
2025-08-15T15:02:39.5956402Z C compiler failed compiling: ../src\unix\Common/Usocket.c
2025-08-15T15:02:39.5956675Z new source -> compiling UdirC.c

...



...
https://github.com/modula3/cm3/commit/d33eb63501d23ae026489e179f522f246a6350b9
...



...
-   m3c_socklen_t len = {0};                    \
+   m3c_socklen_t len = {*plen};                    \
...

[demoitem]

So, bad news.

…

On Sat, 16 Aug 2025 at 4:36 am, VictorMiasnikov ***@***.***> wrote: *VictorMiasnikov* left a comment (modula3/cm3#1196) <#1196 (comment)> There was a small bug in Usocket.c The len param was not being initialised. Should be fixed now. We have Non-good news: 8_I386_NT _ build (c).txt 5_I386_NT _ build (integrated).txt ... 2025-08-15T15:02:39.5953189Z new source -> compiling Usocket.c 2025-08-15T15:02:39.5953372Z Usocket.c 2025-08-15T15:02:39.5953766Z ../src\unix\Common/Usocket.c(471): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion 2025-08-15T15:02:39.5954449Z ../src\unix\Common/Usocket.c(481): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion 2025-08-15T15:02:39.5955104Z ../src\unix\Common/Usocket.c(491): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion 2025-08-15T15:02:39.5955755Z ../src\unix\Common/Usocket.c(546): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion 2025-08-15T15:02:39.5956175Z compile_c => 2 2025-08-15T15:02:39.5956402Z C compiler failed compiling: ../src\unix\Common/Usocket.c 2025-08-15T15:02:39.5956675Z new source -> compiling UdirC.c ... ... d33eb63 <d33eb63> ... ... - m3c_socklen_t len = {0}; \ - m3c_socklen_t len = {*plen}; ... — Reply to this email directly, view it on GitHub <#1196 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABALZX5I6VFZCYMZCXJU7XT3NYSCLAVCNFSM6AAAAABTSBSBJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOJSGM4TQNJWGM> . You are receiving this because you commented.Message ID: ***@***.***>

[VictorMiasnikov]

As small remark: I revert corresponded commit. In "my branch". See later why. ( How ask full right to master / main branch? I've read rules: It possible)

…

---------------- Кому: modula3/cm3 ***@***.***); Копия: Comment ***@***.***); Тема: [modula3/cm3] getsockname() breakage? AMD64_LINUX (Issue #1196); 16.08.2025, 04:51, "peter mckinna" ***@***.***>: demoitem left a comment (modula3/cm3#1196) So, bad news.

On Sat, 16 Aug 2025 at 4:36 am, VictorMiasnikov ***@***.***> wrote: *VictorMiasnikov* left a comment (modula3/cm3#1196) <#1196 (comment)> There was a small bug in Usocket.c The len param was not being initialised. Should be fixed now. We have Non-good news: 8_I386_NT _ build (c).txt 5_I386_NT _ build (integrated).txt ... 2025-08-15T15:02:39.5953189Z new source -> compiling Usocket.c 2025-08-15T15:02:39.5953372Z Usocket.c 2025-08-15T15:02:39.5953766Z ../src\unix\Common/Usocket.c(471): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion 2025-08-15T15:02:39.5954449Z ../src\unix\Common/Usocket.c(481): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion 2025-08-15T15:02:39.5955104Z ../src\unix\Common/Usocket.c(491): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion 2025-08-15T15:02:39.5955755Z ../src\unix\Common/Usocket.c(546): error C2397: conversion from 'm3_socklen_t' to 'socklen_t' requires a narrowing conversion 2025-08-15T15:02:39.5956175Z compile_c => 2 2025-08-15T15:02:39.5956402Z C compiler failed compiling: ../src\unix\Common/Usocket.c 2025-08-15T15:02:39.5956675Z new source -> compiling UdirC.c ... ... d33eb63 <d33eb63> ... ... - m3c_socklen_t len = {0}; \ - m3c_socklen_t len = {*plen}; ... —

[VictorMiasnikov]

I see
d965c51

It looks ( I'm not check de-facto now) good.

Thank!