Summary branch has 33 commits for 23w06a instead of once

[misode]

Really weird and needs to be regenerated, but not technically a critical issue

[boblmbq]

Hi misode, i appreciate your work and hope you will still update the files for further versions of minecraft.

I'm writting a datapack for 1.21.4 that makes the generation of specific ores in some biomes rarer or more common. I have used your files for changing the biomes ore generation like https://github.com/misode/mcmeta/blob/data-json/data/minecraft/worldgen/biome/deep_frozen_ocean.json and found out that all or some of the files in the array with index 9, so the 10th array, in the array "features" are causing an error like this:

z: Exception generating new chunk
at aqi.a(SourceFile:681) ~[minecraft-1.21.4-client.jar:?]
at bra.d(SourceFile:164) ~[minecraft-1.21.4-client.jar:?]
at ara$b.d(SourceFile:602) ~[minecraft-1.21.4-client.jar:?]
at bra.B(SourceFile:138) ~[minecraft-1.21.4-client.jar:?]
at ara$b.B(SourceFile:611) ~[minecraft-1.21.4-client.jar:?]
at bra.b(SourceFile:147) ~[minecraft-1.21.4-client.jar:?]
at ara$b.b(SourceFile:575) ~[minecraft-1.21.4-client.jar:?]
at ara.a(SourceFile:151) ~[minecraft-1.21.4-client.jar:?]
at dgj.a(SourceFile:209) ~[minecraft-1.21.4-client.jar:?]
at dgm.a(SourceFile:151) ~[minecraft-1.21.4-client.jar:?]
at dgj.d(SourceFile:203) ~[minecraft-1.21.4-client.jar:?]
at aqx.a(SourceFile:23) ~[minecraft-1.21.4-client.jar:?]
at aqx.a(SourceFile:64) ~[minecraft-1.21.4-client.jar:?]
at net.minecraft.server.MinecraftServer.a(SourceFile:467) ~[minecraft-1.21.4-client.jar:?]
at net.minecraft.server.MinecraftServer.a(SourceFile:400) ~[minecraft-1.21.4-client.jar:?]
at net.minecraft.server.MinecraftServer.v_(SourceFile:356) ~[minecraft-1.21.4-client.jar:?]
at hje.e(SourceFile:73) ~[minecraft-1.21.4-client.jar:?]
at net.minecraft.server.MinecraftServer.y(SourceFile:678) ~[minecraft-1.21.4-client.jar:?]
at net.minecraft.server.MinecraftServer.a(SourceFile:292) ~[minecraft-1.21.4-client.jar:?]
at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
Caused by: java.lang.IllegalStateException: Feature order cycle found, involved sources: [Reference{ResourceKey[minecraft:worldgen/biome / minecraft:deep_frozen_ocean]=dhl@28e7e641}, Reference{ResourceKey[minecraft:worldgen/biome / minecraft:deep_dark]=dhl@2cdcf975}]
at dhv.a(SourceFile:99) ~[minecraft-1.21.4-client.jar:?]
at dyu.a(SourceFile:103) ~[minecraft-1.21.4-client.jar:?]
at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:200) ~[guava-33.3.1-jre.jar:?]
at dyu.a(SourceFile:293) ~[minecraft-1.21.4-client.jar:?]
at dzw.i(SourceFile:102) ~[minecraft-1.21.4-client.jar:?]
at dzx.a(SourceFile:33) ~[minecraft-1.21.4-client.jar:?]
at aqi.a(SourceFile:666) ~[minecraft-1.21.4-client.jar:?]
at aqu.a(SourceFile:101) ~[minecraft-1.21.4-client.jar:?]
at aqf.a(SourceFile:148) ~[minecraft-1.21.4-client.jar:?]
at aqf.a(SourceFile:125) ~[minecraft-1.21.4-client.jar:?]
at aqf.d(SourceFile:76) ~[minecraft-1.21.4-client.jar:?]
at aqf.a(SourceFile:61) ~[minecraft-1.21.4-client.jar:?]
at aqi.b(SourceFile:700) ~[minecraft-1.21.4-client.jar:?]
at aqk.a(SourceFile:88) ~[minecraft-1.21.4-client.jar:?]
at brg.a(SourceFile:21) ~[minecraft-1.21.4-client.jar:?]
at af.a(SourceFile:296) ~[minecraft-1.21.4-client.jar:?]
at bqz.f(SourceFile:50) ~[minecraft-1.21.4-client.jar:?]
at bqz.run(SourceFile:62) ~[minecraft-1.21.4-client.jar:?]
at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1423) ~[?:?]
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387) ~[?:?]
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1310) ~[?:?]
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1841) ~[?:?]
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1806) ~[?:?]
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188) ~[?:?]

I also found out what files or references (idk) cause the error, I set a "<--" to them:

[
"minecraft:glow_lichen",
"minecraft:trees_water",
"minecraft:flower_default",
"minecraft:patch_grass_badlands", <--
"minecraft:brown_mushroom_normal", <--
"minecraft:red_mushroom_normal", <--
"minecraft:patch_pumpkin", <--
"minecraft:patch_sugar_cane", <--
"minecraft:patch_firefly_bush_near_water" <--
]

I asked ChatGPT why the error happens and he answered:

• deep_frozen_ocean includes a feature that references a biome or condition from deep_dark, or vice versa.
• Or both biomes include each other’s features directly or indirectly.
• This creates a circular dependency in the worldgen features graph.

I think you are more experienced in this field and probably can understand better how to fix this problem, because everything I did, was just deleting all the "error" files (or references) and that is it.

I hope my comment will help you with this repo and I hope you will answer with a decision on how i may fix the problem in some other and maybe better way.

Thank you for the time reading it!!

[boblmbq]

Hi misode again, I just found the description of the problem.

https://fruitful-generator.github.io/guides/feature-order-cycle/

This might be it.

[misode]

@boblmbq Hi, your question is unrelated to this issue and unrelated to this repo. I suggest you try to get help on the Minecarft Commands discord: https://discord.gg/QAFXFtZ