ci: bump datum-cloud/actions refs in publish-ui-npm to v1.15.0#205
Open
kevwilliams wants to merge 1 commit into
Open
ci: bump datum-cloud/actions refs in publish-ui-npm to v1.15.0#205kevwilliams wants to merge 1 commit into
kevwilliams wants to merge 1 commit into
Conversation
Picks up datum-cloud/actions#72, which fixes bump-npm-version so the package.json bump commit actually lands on main (previously the bump happened on a detached HEAD and main was never advanced, causing publish-release to republish the prior version). After this lands, workflow_dispatch with a bump-type will correctly bump ui/package.json on main; manual version bumps in PRs are no longer required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up datum-cloud/actions#72 (released as
v1.15.0), which fixesbump-npm-versionso thepackage.jsonbump commit actually lands onmain.Previously,
actions/checkoutleftHEADdetached andnpm versionmade the bump commit on the detached HEAD, leavingmainunchanged.publish-releasethen republished the prior version. The workaround was to manually bumpui/package.jsonin a PR before triggering release.After this lands,
workflow_dispatchwithbump-type: patch|minor|majorwill correctly:ui/package.jsononmainto the new versionvX.Y.Ztag at the bump commitManual version bumps in PRs are no longer required.
Test plan
Publish UI to NPMwithbump-type: patch. Confirm:ui/package.jsononmainadvances from0.5.1to0.5.2v0.5.2points at the bump commit (not at the merge commit before it)@datum-cloud/activity-ui@0.5.2is published to npm withlatestdist-tagv0.5.2is created