From 346ea7abe2c5aa29ac89540f21b63e6b0fc336a6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 14 May 2026 21:43:08 +0000 Subject: [PATCH 1/3] Initial plan From 31482564cf99d2be602a58c4f85e47d8652bc534 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 14 May 2026 21:48:55 +0000 Subject: [PATCH 2/3] Fix inactive sign-in cmdlet day limit above 30 Agent-Logs-Url: https://github.com/microsoftgraph/entra-powershell/sessions/b508c62b-59ff-4dbc-9b87-ccd23680c2c6 Co-authored-by: reneemichiko <149618348+reneemichiko@users.noreply.github.com> --- .../Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 | 3 +-- .../Users/Get-EntraBetaInactiveSignInUser.ps1 | 3 +-- test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1 | 7 +++++++ .../Users/Get-EntraBetaInactiveSignInUser.Tests.ps1 | 7 +++++++ 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 b/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 index faaa3960ee..29497676c6 100644 --- a/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 +++ b/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 @@ -9,7 +9,7 @@ function Get-EntraInactiveSignInUser { # User Last Sign In Activity is before Days ago [Parameter(ValueFromPipeline = $true, Position = 1)] [Alias("BeforeDaysAgo")] - [ValidateRange(0,30)] + [ValidateRange(0, 2147483647)] [int] $LastSignInBeforeDaysAgo = 30, # Return results for All, Member, or Guest userTypes [ValidateSet("All", "Member", "Guest")] @@ -109,4 +109,3 @@ function Get-EntraInactiveSignInUser { } } } - diff --git a/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 b/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 index d1c6400558..900c7a30c3 100644 --- a/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 +++ b/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 @@ -9,7 +9,7 @@ function Get-EntraBetaInactiveSignInUser { # User Last Sign In Activity is before Days ago [Parameter(ValueFromPipeline = $true, Position = 1)] [Alias("BeforeDaysAgo")] - [ValidateRange(0,30)] + [ValidateRange(0, 2147483647)] [int] $LastSignInBeforeDaysAgo = 30, # Return results for All, Member, or Guest userTypes [ValidateSet("All", "Member", "Guest")] @@ -108,4 +108,3 @@ function Get-EntraBetaInactiveSignInUser { } } - diff --git a/test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1 b/test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1 index bdf882e81f..ca6510cb58 100644 --- a/test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1 +++ b/test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1 @@ -83,6 +83,13 @@ Describe 'Get-EntraInactiveSignInUser' { $result[2].UserID | Should -Be "user3" } + It "Should allow LastSignInBeforeDaysAgo above 30" { + $result = Get-EntraInactiveSignInUser -LastSignInBeforeDaysAgo 90 -UserType "All" + + $result | Should -Not -BeNullOrEmpty + Should -Invoke -CommandName Invoke-GraphRequest -ModuleName Microsoft.Entra.Users -Times 1 + } + It "Should return only inactive Member users" { $result = Get-EntraInactiveSignInUser -LastSignInBeforeDaysAgo 30 -UserType "Member" diff --git a/test/EntraBeta/Users/Get-EntraBetaInactiveSignInUser.Tests.ps1 b/test/EntraBeta/Users/Get-EntraBetaInactiveSignInUser.Tests.ps1 index e038009d29..286ff57f76 100644 --- a/test/EntraBeta/Users/Get-EntraBetaInactiveSignInUser.Tests.ps1 +++ b/test/EntraBeta/Users/Get-EntraBetaInactiveSignInUser.Tests.ps1 @@ -84,6 +84,13 @@ Describe 'Get-EntraBetaInactiveSignInUser' { $result[2].UserID | Should -Be "user3" } + It "Should allow LastSignInBeforeDaysAgo above 30" { + $result = Get-EntraBetaInactiveSignInUser -LastSignInBeforeDaysAgo 90 -UserType "All" + + $result | Should -Not -BeNullOrEmpty + Should -Invoke -CommandName Invoke-GraphRequest -ModuleName Microsoft.Entra.Beta.Users -Times 1 + } + It "Should return only inactive Member users" { $result = Get-EntraBetaInactiveSignInUser -LastSignInBeforeDaysAgo 30 -UserType "Member" From b8d7d51d82d7766cd7d4fa8277938e77150eb06f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 14 May 2026 21:49:42 +0000 Subject: [PATCH 3/3] Refine day range validation to use int max constant Agent-Logs-Url: https://github.com/microsoftgraph/entra-powershell/sessions/b508c62b-59ff-4dbc-9b87-ccd23680c2c6 Co-authored-by: reneemichiko <149618348+reneemichiko@users.noreply.github.com> --- .../Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 | 2 +- .../Users/Get-EntraBetaInactiveSignInUser.ps1 | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 b/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 index 29497676c6..f6c2c9b607 100644 --- a/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 +++ b/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 @@ -9,7 +9,7 @@ function Get-EntraInactiveSignInUser { # User Last Sign In Activity is before Days ago [Parameter(ValueFromPipeline = $true, Position = 1)] [Alias("BeforeDaysAgo")] - [ValidateRange(0, 2147483647)] + [ValidateRange(0, [int]::MaxValue)] [int] $LastSignInBeforeDaysAgo = 30, # Return results for All, Member, or Guest userTypes [ValidateSet("All", "Member", "Guest")] diff --git a/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 b/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 index 900c7a30c3..e62e701b2e 100644 --- a/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 +++ b/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 @@ -9,7 +9,7 @@ function Get-EntraBetaInactiveSignInUser { # User Last Sign In Activity is before Days ago [Parameter(ValueFromPipeline = $true, Position = 1)] [Alias("BeforeDaysAgo")] - [ValidateRange(0, 2147483647)] + [ValidateRange(0, [int]::MaxValue)] [int] $LastSignInBeforeDaysAgo = 30, # Return results for All, Member, or Guest userTypes [ValidateSet("All", "Member", "Guest")] @@ -107,4 +107,3 @@ function Get-EntraBetaInactiveSignInUser { } } } -