diff --git a/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 b/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 index faaa3960e..f6c2c9b60 100644 --- a/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 +++ b/module/Entra/Microsoft.Entra/Users/Get-EntraInactiveSignInUser.ps1 @@ -9,7 +9,7 @@ function Get-EntraInactiveSignInUser { # User Last Sign In Activity is before Days ago [Parameter(ValueFromPipeline = $true, Position = 1)] [Alias("BeforeDaysAgo")] - [ValidateRange(0,30)] + [ValidateRange(0, [int]::MaxValue)] [int] $LastSignInBeforeDaysAgo = 30, # Return results for All, Member, or Guest userTypes [ValidateSet("All", "Member", "Guest")] @@ -109,4 +109,3 @@ function Get-EntraInactiveSignInUser { } } } - diff --git a/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 b/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 index d1c640055..e62e701b2 100644 --- a/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 +++ b/module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaInactiveSignInUser.ps1 @@ -9,7 +9,7 @@ function Get-EntraBetaInactiveSignInUser { # User Last Sign In Activity is before Days ago [Parameter(ValueFromPipeline = $true, Position = 1)] [Alias("BeforeDaysAgo")] - [ValidateRange(0,30)] + [ValidateRange(0, [int]::MaxValue)] [int] $LastSignInBeforeDaysAgo = 30, # Return results for All, Member, or Guest userTypes [ValidateSet("All", "Member", "Guest")] @@ -107,5 +107,3 @@ function Get-EntraBetaInactiveSignInUser { } } } - - diff --git a/test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1 b/test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1 index bdf882e81..ca6510cb5 100644 --- a/test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1 +++ b/test/Entra/Users/Get-EntraInactiveSignInUser.Tests.ps1 @@ -83,6 +83,13 @@ Describe 'Get-EntraInactiveSignInUser' { $result[2].UserID | Should -Be "user3" } + It "Should allow LastSignInBeforeDaysAgo above 30" { + $result = Get-EntraInactiveSignInUser -LastSignInBeforeDaysAgo 90 -UserType "All" + + $result | Should -Not -BeNullOrEmpty + Should -Invoke -CommandName Invoke-GraphRequest -ModuleName Microsoft.Entra.Users -Times 1 + } + It "Should return only inactive Member users" { $result = Get-EntraInactiveSignInUser -LastSignInBeforeDaysAgo 30 -UserType "Member" diff --git a/test/EntraBeta/Users/Get-EntraBetaInactiveSignInUser.Tests.ps1 b/test/EntraBeta/Users/Get-EntraBetaInactiveSignInUser.Tests.ps1 index e038009d2..286ff57f7 100644 --- a/test/EntraBeta/Users/Get-EntraBetaInactiveSignInUser.Tests.ps1 +++ b/test/EntraBeta/Users/Get-EntraBetaInactiveSignInUser.Tests.ps1 @@ -84,6 +84,13 @@ Describe 'Get-EntraBetaInactiveSignInUser' { $result[2].UserID | Should -Be "user3" } + It "Should allow LastSignInBeforeDaysAgo above 30" { + $result = Get-EntraBetaInactiveSignInUser -LastSignInBeforeDaysAgo 90 -UserType "All" + + $result | Should -Not -BeNullOrEmpty + Should -Invoke -CommandName Invoke-GraphRequest -ModuleName Microsoft.Entra.Beta.Users -Times 1 + } + It "Should return only inactive Member users" { $result = Get-EntraBetaInactiveSignInUser -LastSignInBeforeDaysAgo 30 -UserType "Member"