[Azure Generator] Upgrade to @typespec/http-client-csharp 1.0.0-alpha.20260312.2 and implement Azure ClientSettings support (#57042) * Initial plan * Initial setup: upgrade @typespec/http-client-csharp to 1.0.0-alpha.20260312.2 Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Upgrade UnbrandedGeneratorVersion to 1.0.0-alpha.20260312.2 Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Apply suggestion from @JoshLove-msft * Re-run npm install after fixing package.json version to remove caret Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Add ClientSettingsVisitor and regenerate Basic-TypeSpec test project Implements Azure-specific overrides for ClientSettings generation: - ClientSettings: adds Partial modifier for user extensibility - ClientOptions IConfigurationSection ctor: base(section, null) for Azure.Core - Regenerated Basic-TypeSpec with new Settings/Options constructors Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Add unit tests for ClientSettingsVisitor Tests verify: - ClientSettings has Public|Partial|Class modifiers - ClientOptions IConfigurationSection ctor uses base(section, null) - Sub-clients don't have ClientSettings/ClientOptions Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Strengthen test to verify null keyword in constructor initializer Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Remove ClientSettings modifier change per review - should be fixed in base generator Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Add ConfigureLogging as partial method on ClientOptions and call from all constructors Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Fix TestBuildAuthFields_WithAuth tests and apply StubLibraryVisitor changes from base generator Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Replace ConfigureLogging with separate ConfigureLoggedHeaderDefaults and ConfigureLoggedQueryParameterDefaults partial methods Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Revert to single ConfigureLogging() partial method per review feedback Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Implement ClientSettings constructor changes: remove AuthenticationPolicy ctor, chain Settings to TokenCredential - ClientSettingsVisitor now uses VisitConstructor to remove internal AuthenticationPolicy constructor and modify Settings constructor to use settings.TokenProvider as TokenCredential - Inlines pipeline building body into credential-based constructors - Added tests for new behavior - Note: VisitConstructor integration with ClientProvider needs further investigation Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Support AzureKeyCredential-only clients in Settings constructor generation When a client has only an AzureKeyCredential constructor (no TokenCredential), the Settings constructor is still generated and chains to the AzureKeyCredential constructor using settings?.TokenProvider as AzureKeyCredential. The Settings/ctor is only removed if neither credential type constructor exists. Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Fix AzureKeyCredential path to check CredentialSource and construct credential For key-credential-only libraries, the Settings constructor now generates: string.Equals(settings?.Credential?.CredentialSource, "apikeycredential", StringComparison.OrdinalIgnoreCase) ? new AzureKeyCredential(settings.Credential.Key) : null Instead of the incorrect `settings?.TokenProvider as AzureKeyCredential` cast. Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Fix visitor: use AsExpression for 'as' cast, change internal ctor param to HttpPipelinePolicy, use correct CredentialProvider property name, move constructor changes to Visit() for test compatibility Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Address review feedback: use .Property(nameof()), StringSnippets.Equals, remove MemberExpression constructors Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Fix build errors: remove compile-time AuthenticationPolicy dependency, use string literal instead Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Replace string literal "AuthenticationPolicy" with nameof(AuthenticationPolicy) since SCM types are available Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Remove internal AuthenticationPolicy constructor and inline body into credential constructors via VisitConstructor Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Fix ClientSettingsVisitor: change AuthenticationPolicy param type instead of inlining - Change internal constructor's AuthenticationPolicy parameter type to HttpPipelinePolicy instead of deleting the constructor and inlining its body (which was buggy and caused build errors) - Always generate ClientSettings constructor for all clients, not just those with credentials. No-credential clients chain to the internal constructor with null for the auth policy parameter. - Add ExperimentalAttribute.cs shared source to NewAzureProjectScaffolding for netstandard2.0/pre-.NET 8 target compatibility - Update tests and regenerate all test projects Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add tests for key-credential-only and no-credential client Settings constructor scenarios Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Improve no-credential test: use type-safe Settings type check and verify null display string Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Fix no-auth Settings ctor: replace AuthenticationPolicy.Create with null For clients without credential support, replace the base-generated AuthenticationPolicy.Create(settings) call with a cast-to-null expression so the internal constructor receives a null auth policy. The cast to HttpPipelinePolicy disambiguates constructor overloads where needed (Roslyn reduce removes the cast where it's unnecessary). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update http-client-csharp emitter to 1.0.0-alpha.20260312.2 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Disable client-initialization default/individually scenarios pending paramAlias fix Revert generated code for default and individually client-initialization projects to pre-Settings state. These scenarios fail due to a paramAlias bug in the base TypeSpec C# generator where BuildSettingsConstructors produces mismatched argument counts. Tracked in: https://github.com/microsoft/typespec/issues/9774 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore AzureGeneratorVersion and AzureManagementGeneratorVersion from main Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix build * Make AIProjectClientSettings custom and fix ClientSettingsVisitor type comparisons - Move AIProjectClientSettings from Generated to Custom since AIP uses non-standard constructor patterns - Move settings constructor from Generated to Custom AIProjectClient.cs - Update ClientSettingsVisitor to use CSharpType.Equals instead of string name comparisons Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Regenerated SDK code for ai and transcription service directories Regenerated output from updated generator with ClientSettings support. Includes regenerated code for: - Azure.AI.Projects - Azure.AI.Projects.Agents - Azure.AI.Extensions.OpenAI - Azure.AI.Agents.Persistent - Azure.AI.Speech.Transcription - Azure.AI.Inference Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Make InternalProjectsClientSettings custom for Agents and OpenAI projects Apply the same customization pattern as AIProjectClient: - Move InternalProjectsClientSettings from Generated to Custom for both projects - Move settings constructor from Generated to Custom InternalProjectsClient Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Revert Agents/OpenAI settings customization and export APIs Reverted InternalProjectsClient settings customization for Agents and OpenAI - these follow the standard pattern and don't need custom files. CI regenerates Generated/ files, causing duplicate attribute errors. Exported public API listings for ai and transcription service directories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add custom settings for AgentsClient and ProjectOpenAIClient - Add AgentsClientSettings with custom settings constructor and internal AuthenticationPolicy constructor for AgentsClient - Add ProjectOpenAIClientSettings with settings constructor chaining to existing AuthenticationPolicy constructor for ProjectOpenAIClient - Export API listings for both libraries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Move AIProjectClientSettings back to Generated to avoid CI duplicate CI regenerates Generated/ files, causing duplicate partial class conflicts. The Settings class itself follows the standard pattern - only the settings constructor on AIProjectClient needs to be custom. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Regenerate Azure.AI.Extensions.OpenAI Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Regenerate Azure.AI.Projects.Agents Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix duplicate ConfigureLogging when multiple clients share singleton ClientOptions When multiple clients share a singleton ClientOptionsProvider, the visitor's UpdateClientOptions was called once per client, appending ConfigureLogging() each time. Track visited options instances with a HashSet to ensure UpdateClientOptions runs only once per instance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Regenerate test projects after ConfigureLogging fix Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Co-authored-by: jolov Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Need to support paramAlias decorator #9774

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions