Skip to content

refactor: Strangler Stage 1 -- tame worst complexity outliers #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergio-sisternes-epam wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: Strangler Stage 1 -- tame worst complexity outliers #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1a4861
refactor: Strangler Stage 1 -- tame worst complexity outliers (#1077)
May 23, 2026
ffaef8e
Merge branch 'main' into sergio-sisternes-epam/issue-1077-strangler-s…
sergio-sisternes-epam May 23, 2026
85b29e3
fix: address Copilot + APM panel review feedback (#1077)
May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
run: |
# Ruff has no max-module-lines rule. This check prevents new files from
# exceeding the current worst case. Tighten the threshold over time.
MAX_LINES=2450 # current max: 2404 (github_downloader.py)
MAX_LINES=2000 # Stage 1 (was 2450); target 1400 deferred to Stage 2
VIOLATIONS=$(find src/ -name '*.py' -print0 | xargs -0 -I{} awk -v max="$MAX_LINES" \
'END { if (NR > max) printf "%s: %d lines (max %d)\n", FILENAME, NR, max }' {})
if [ -n "$VIOLATIONS" ]; then
Expand Down
14 changes: 8 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,16 @@ ignore = [
# High initial thresholds set just above current codebase maximums.
# Prevents new code from exceeding the worst existing violations.
# Tighten these over time via dedicated refactoring PRs.
max-statements = 275 # current max: 269 (mcp_integrator.py::install)
max-args = 18 # current max: 16 (commands/install.py)
max-branches = 115 # current max: 108 (mcp_integrator.py::install)
max-returns = 18 # current max: 16 (marketplace/publisher.py)
# Stage 1 thresholds (PR #1464, issue #1077).
# Roadmap: Stage 2 targets max-complexity<=20, max-branches<=25 (McCabe standard).
max-statements = 200 # Stage 1 (was 275)
max-args = 15 # Stage 1 (was 18)
max-branches = 60 # Stage 1 (was 115)
max-returns = 12 # Stage 1 (was 18)

[tool.ruff.lint.mccabe]
max-complexity = 100 # current max: 97 (mcp_integrator.py::install)
# Stage 1 (was 100). Stage 2 target: <=20 (McCabe industry standard).
max-complexity = 50

[tool.ruff.lint.per-file-ignores]
# Subprocess calls are intentional in a CLI tool
Expand All @@ -120,7 +123,6 @@ max-complexity = 100 # current max: 97 (mcp_integrator.py::install)
"src/apm_cli/commands/init.py" = ["F821", "S603", "S607"]
"src/apm_cli/install/pipeline.py" = ["F821", "S603", "S607"]
"src/apm_cli/integration/skill_integrator.py" = ["F821", "S603", "S607"]

[tool.ruff.format]
quote-style = "double"
indent-style = "space"
Expand Down
Loading
Loading