From 249b895d8c86285b9921ca74dd36fed34f382a06 Mon Sep 17 00:00:00 2001 From: Tyrie Vella Date: Tue, 26 May 2026 11:46:59 -0700 Subject: [PATCH] Fix flaky CreatePlaceholderTests stderr comparison Git's "Updating files" progress output on stderr is timing-dependent, causing ErrorsShouldMatch to fail when one repo emits progress and the other does not. Set GIT_PROGRESS_DELAY=3600 on all test git invocations so progress output is never emitted for commands completing under an hour. This eliminates the flake at the source without skipping error validation. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella --- GVFS/GVFS.FunctionalTests/Tools/GitProcess.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/GVFS/GVFS.FunctionalTests/Tools/GitProcess.cs b/GVFS/GVFS.FunctionalTests/Tools/GitProcess.cs index bc2135465..abc94f06d 100644 --- a/GVFS/GVFS.FunctionalTests/Tools/GitProcess.cs +++ b/GVFS/GVFS.FunctionalTests/Tools/GitProcess.cs @@ -35,6 +35,9 @@ public static ProcessResult InvokeProcess( } processInfo.EnvironmentVariables["GIT_TERMINAL_PROMPT"] = "0"; + // Suppress progress output (e.g. "Updating files: 100%") which is timing-dependent + // and causes flaky stderr comparisons between control and GVFS repos. + processInfo.EnvironmentVariables["GIT_PROGRESS_DELAY"] = "3600"; if (environmentVariables != null) {