formatting

Author: mrm9084

featuremanagement/_time_window_filter/_recurrence_evaluator.py

@@ -49,6 +49,8 @@ def _get_previous_occurrence(recurrence: Recurrence, start: datetime, now: datet
         occurrence_info = _get_daily_previous_occurrence(recurrence, start, now)
     elif pattern_type == RecurrencePatternType.WEEKLY:
         occurrence_info = _get_weekly_previous_occurrence(recurrence, start, now)
+    else:
+        raise ValueError(f"Unsupported recurrence pattern type: {pattern_type}")
 
     recurrence_range = recurrence.range
     range_type = recurrence_range.type

featuremanagement/_time_window_filter/_recurrence_validator.py

@@ -157,8 +157,8 @@ def _sort_days_of_week(days_of_week: List[int], first_day_of_week: int) -> List[
     if first_day_of_week in sorted_days:
         return sorted_days[sorted_days.index(first_day_of_week) :] + sorted_days[: sorted_days.index(first_day_of_week)]
     next_closet_day = first_day_of_week
-    for i in range(len(sorted_days)):
-        if sorted_days[i] > first_day_of_week:
-            next_closet_day = sorted_days[i]
+    for day in sorted_days:
+        if day > first_day_of_week:
+            next_closet_day = day
             break
     return sorted_days[sorted_days.index(next_closet_day) :] + sorted_days[: sorted_days.index(next_closet_day)]

tests/time_window_filter/test_recurrence_evaluator.py

@@ -1,5 +1,10 @@
+# ------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+# -------------------------------------------------------------------------
+from datetime import datetime
 import pytest
-from datetime import datetime, timedelta
 from featuremanagement._time_window_filter._recurrence_evaluator import is_match
 from featuremanagement._time_window_filter._models import TimeWindowFilterSettings, Recurrence
 
@@ -186,6 +191,7 @@ def test_is_match_weekly_recurrence_with_occurrences_single_day():
     # Fifth week occurrence shouldn't match, passed the range
     assert is_match(settings, datetime(2025, 5, 5, 10, 0, 0)) is False
 
+
 def test_is_match_weekly_recurrence_with_occurrences_multi_day():
     start = datetime(2025, 4, 7, 9, 0, 0)  # Monday
     end = datetime(2025, 4, 7, 17, 0, 0)  # Monday
@@ -253,7 +259,7 @@ def test_weekly_recurrence_start_after_min_offset():
 def test_weekly_recurrence_now_before_min_offset():
     start = datetime(2025, 4, 9, 9, 0, 0)  # Monday
     end = datetime(2025, 4, 9, 17, 0, 0)  # Monday
-    now = datetime(2025, 4, 16, 8, 0, 0) 
+    now = datetime(2025, 4, 16, 8, 0, 0)
 
     recurrence = Recurrence(
         {
@@ -271,4 +277,3 @@ def test_weekly_recurrence_now_before_min_offset():
 
     # Verify that the main method is_match correctly handles the scenario
     assert is_match(settings, now) is False
-

tests/time_window_filter/test_recurrence_validator.py

@@ -1,3 +1,8 @@
+# ------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+# -------------------------------------------------------------------------
 from datetime import timedelta, datetime
 import pytest
 from recurrence_util import valid_daily_recurrence, valid_daily_end_date_recurrence, valid_no_end_range, START, END