update

Author: zhiyuanliang-ms

.gitignore

@@ -413,3 +413,5 @@ examples/**/**/package-lock.json
 
 # playwright test result
 test-results
+
+**/public

examples/express-app/server.mjs

@@ -16,7 +16,7 @@ const exampleTargetingContextAccessor = {
     getTargetingContext: () => {
         const req = requestAccessor.getStore();
         if (req === undefined) {
-            return { userId: undefined, groups: [] };
+            return undefined;
         }
         // read user and groups from request query data
         const { userId, groups } = req.query;

examples/quote-of-the-day/client/src/pages/Home.jsx

@@ -39,7 +39,7 @@ function Home() {
           headers: {
             "Content-Type": "application/json",
           },
-          body: JSON.stringify({ UserId: currentUser ?? "" }),
+          body: JSON.stringify({ userId: currentUser ?? "" }),
         });
 
         if (response.ok) {

examples/quote-of-the-day/server.js

@@ -19,10 +19,11 @@ const exampleTargetingContextAccessor = {
     getTargetingContext: () => {
         const req = requestAccessor.getStore();
         if (req === undefined) {
-            return { userId: undefined, groups: [] };
+            return undefined;
         }
-        // read user and groups from request query data
-        const { userId, groups } = req.query;
+        // read user and groups from request
+        const userId = req.query.userId ?? req.body.userId;
+        const groups = req.query.groups ?? req.body.groups;
         // return an ITargetingContext with the appropriate user info
         return { userId: userId, groups: groups ? groups.split(",") : [] };
     }
@@ -43,7 +44,7 @@ applicationInsights.defaultClient.addTelemetryProcessor(createTargetingTelemetry
 
 const { load } = require("@azure/app-configuration-provider");
 const { FeatureManager, ConfigurationMapFeatureFlagProvider } = require("@microsoft/feature-management");
-const { createTelemetryPublisher, trackEvent } = require("@microsoft/feature-management-applicationinsights-node");
+const { createTelemetryPublisher } = require("@microsoft/feature-management-applicationinsights-node");
 let appConfig;
 let featureManager;
 async function initializeConfig() {
@@ -103,11 +104,11 @@ function startServer() {
     });
 
     server.post("/api/like", (req, res) => {
-        const { UserId } = req.body;
-        if (UserId === undefined) {
+        const { userId } = req.body;
+        if (userId === undefined) {
             return res.status(400).send({ error: "UserId is required" });
         }
-        trackEvent(applicationInsights.defaultClient, UserId, { name: "Like" });
+        applicationInsights.defaultClient.trackEvent({ name: "Like" });
         res.status(200).send({ message: "Like event logged successfully" });
     });
 

src/feature-management-applicationinsights-browser/src/telemetry.ts

@@ -48,9 +48,11 @@ export function trackEvent(client: ApplicationInsights, targetingId: string, eve
 export function createTargetingTelemetryInitializer(targetingContextAccessor: ITargetingContextAccessor): (item: ITelemetryItem) => void {
     return (item: ITelemetryItem) => {
         const targetingContext = targetingContextAccessor.getTargetingContext();
-        if (targetingContext?.userId === undefined) {
-            console.warn("Targeting id is undefined.");
+        if (targetingContext !== undefined) {
+            if (targetingContext?.userId === undefined) {
+                console.warn("Targeting id is undefined.");
+            }
+            item.data = {...item.data, [TARGETING_ID]: targetingContext?.userId || ""};
         }
-        item.data = {...item.data, [TARGETING_ID]: targetingContext?.userId || ""};
     };
 }

src/feature-management-applicationinsights-node/src/telemetry.ts

@@ -48,11 +48,13 @@ export function trackEvent(client: TelemetryClient, targetingId: string, event:
 export function createTargetingTelemetryProcessor(targetingContextAccessor: ITargetingContextAccessor): (envelope: Contracts.EnvelopeTelemetry) => boolean {
     return (envelope: Contracts.EnvelopeTelemetry) => {
         const targetingContext = targetingContextAccessor.getTargetingContext();
-        if (targetingContext?.userId === undefined) {
-            console.warn("Targeting id is undefined.");
+        if (targetingContext !== undefined) {
+            if (targetingContext?.userId === undefined) {
+                console.warn("Targeting id is undefined.");
+            }
+            envelope.data.baseData = envelope.data.baseData || {};
+            envelope.data.baseData.properties = {...envelope.data.baseData.properties, [TARGETING_ID]: targetingContext?.userId || ""};
         }
-        envelope.data.baseData = envelope.data.baseData || {};
-        envelope.data.baseData.properties = {...envelope.data.baseData.properties, [TARGETING_ID]: targetingContext?.userId || ""};
-        return true; // If a telemetry processor returns false, that telemetry item isn't sent.
+        return true;
     };
 }