Skip to content

IgnoreMissingFeatureFilters Option Should Not Throw For RequirementType.All #586

@rthomas-rdm

Description

@rthomas-rdm

Problem:
FeatureManagementOptions.IgnoreMissingFeatureFilters when true will throw if a feature has RequirementType.All set.

This implementation is extremely limiting as it prevents a global level option from being specified and used for requirement type Any features if a single feature of any number of potential features uses requirement type All.

Proposed Solution:

  • Remove the throw condition linked above, and allow the option to be specified even if some features use RequirementType.All
  • Update this IF condition instead to to be if (!_options.IgnoreMissingFeatureFilters || featureDefinition.RequirementType == RequirementType.All) { .. }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions