acp init#171
Conversation
| func (s *Sonic) GetManagement() (ip, user string, err error) { | ||
| ip, err = internal.GetManagementIP("eth0") | ||
| // problem | ||
| ip, err = internal.GetManagementIP("Ethernet0") |
There was a problem hiding this comment.
This is not true for all installations, so at least a flag should be provided
There was a problem hiding this comment.
Wdym with flag?
We are using this PR for testing only right now.
I thought also for the future it would be nice, if we had a way of specifying the port the user wants to use as mgmtport instead of hardcoding it.
There was a problem hiding this comment.
Obviuosly default can be set to eth0, so this is not a breaking change
There was a problem hiding this comment.
Wdym with flag? We are using this PR for testing only right now. I thought also for the future it would be nice, if we had a way of specifying the port the user wants to use as mgmtport instead of hardcoding it.
Then please make a draft PR out of this.
|
@Honigeintopf what is the status of this? |
|
Is needed for the mini rack, let's keep it for a few weeks if still stale I will close it. |
|
Can you explain a bit what it does? Is it really only useful for the mini rack or are there general improvements that we should consider merging? |
4 participants
Description
None