Fix #5: Icon does not appear on EventTrackerButton

Author: Jelte Lagendijk

package.json

@@ -1,6 +1,6 @@
 {
   "name": "GoogleAnalytics",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "description": "",
   "license": "",
   "author": "",

src/GoogleAnalytics/EventTrackerButton.xml

@@ -34,9 +34,9 @@
             </enumerationValues>
         </property>
         <property key="icon" type="image" required="false">
-            <caption>Image</caption>
+            <caption>Icon</caption>
             <category>Appearance</category>
-            <description>Image</description>
+            <description>Icon that appears in front of the caption</description>
         </property>
 
         <property key="onclickmf" type="microflow">
@@ -70,7 +70,7 @@
                 <attributeType name="String"/>
             </attributeTypes>
         </property>
-        <property key="value" type="attribute" required="false"> 
+        <property key="value" type="attribute" required="false">
             <caption>Value</caption>
             <category>Behavior</category>
             <description>Value</description>

src/GoogleAnalytics/widget/EventTrackerButton.js

@@ -7,16 +7,23 @@ define("GoogleAnalytics/widget/EventTrackerButton", [
 
         // Internal variables. Non-primitives created in the prototype are shared between all widget instances.
         _contextObj: null,
+        _iconSet: false,
 
         postCreate: function () {
+            //logger.level(logger.DEBUG);
             logger.debug(this.id + ".postCreate");
+            this._iconSet = (this.icon === "");
             this._insertGoogleAnalytics();
             this.inherited(arguments);
         },
 
         update: function (obj, callback) {
             logger.debug(this.id + ".update");
             this._contextObj = obj;
+            if (!this._iconSet) {
+                this._setIcon(this.icon, false);
+                this._iconSet = true;
+            }
             callback();
         },
 

src/package.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <package xmlns="http://www.mendix.com/package/1.0/">
-    <clientModule name="GoogleAnalytics" version="3.2.0" xmlns="http://www.mendix.com/clientModule/1.0/">
+    <clientModule name="GoogleAnalytics" version="3.2.1" xmlns="http://www.mendix.com/clientModule/1.0/">
         <widgetFiles>
             <widgetFile path="GoogleAnalytics/MasterPageTracker.xml"/>
             <widgetFile path="GoogleAnalytics/PageTracker.xml"/>