Skip to content

bug: Stack ingestion uses URL field instead of Address for Milvus config #48

@maximilien

Description

@maximilien

Description

weave stack ingest fails with "Milvus address is required" because it sets the wrong config field.

Steps to Reproduce

weave stack up --runtime kind
weave stack ingest Documents data/

Expected Behavior

Should set Address field in VectorDBConfig

Actual Behavior

Error:

Error: ingestion failed: failed to create VDB client: invalid_config: Milvus address is required

Root Cause

src/pkg/stack/ingest.go:92 was setting URL field but Milvus client checks Address field:

// Wrong
milvusConfig := &config.VectorDBConfig{
    URL: fmt.Sprintf("localhost:%d", cfg.MilvusLocalPort),
}

// Milvus client code checks:
if config.Address == "" {
    return nil, fmt.Errorf("Milvus: Milvus address is required")
}

Fix

Commit: 813db1f

Changed to correct field:

milvusConfig := &config.VectorDBConfig{
    Address: fmt.Sprintf("localhost:%d", cfg.MilvusLocalPort),
}

Impact

HIGH - Stack ingestion completely broken

Status

FIXED in commit 813db1f

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions