2.7.1

[markcheret]

The latest fix by @pewgeuges has been rolled into the pending release.

How does the planning for 2.7.1 look?
I put it together here https://github.com/markcheret/footnotes/milestone/3

• Achievable until next Friday or do we need more time?
• Any major changes in there that should be moved to 2.8?

[markcheret]

@Rumperuu planned this:

#36 plan on doing in conjunction with #35 which in turn depends on #43 (as type casts and declarations require PHP 7+).

#33 isn't too pressing as we're not renaming any files at the moment; it's a potential gotcha that might catch us out in the future though.
#43 is probably the higher priority, as there have been a couple issues lately revolving around older PHP versions so it will be good to actually have a formal idea of which we do and don't support.

[markcheret]

@lolzim is on #103

[markcheret]

We're ready to test and release.
I have no knowledge on how to minify js and css. So a minification run is still required I guess, before tagging and pushing to WP, right?

https://github.com/markcheret/footnotes/milestone/3

[lolzim]

I have no idea either :-/

[Rumperuu]

I had to minify the stylesheets manually. The pre-release is now out on the GitHub repo. and the SVN repo., done via the release helper script — Stable Tag is still 2.7.0.

The already-existing 2.7.1 tag will need to be deleted so we can push this proper 2.7.1 to tags/.

Cancel that, the SVN version hasn't uploaded correctly.

[lolzim]

Yes, it misses the class/tasks.php file at least.

[Rumperuu]

Fixed - download the archive from the WP Plugin Directory here.

Part of the issue was that svn ci doesn't commit file deletions, so all of the deleted files were staying and throwing fatal errors because they were looking for the now-renamed MCI_* classes. I've now fixed the SVN deletion in the release helper in #127.

I'm not sure why the first time around all of the files under class/ weren't changed. Hopefully the process will have been nailed down enough by 2.8 that whatever it was will be sorted.

[lolzim]

OK, got it in my test WP. It seems OK.

NB: I saw this after uploading the .zip:

Shouldn't it show the min WP & PHP versions requested?

And, once installed, it knows 'em:

🤨

[markcheret]

I just saw the commit emails on SVN..
Thanks for the work and bugfixing that went along with the SVN monstrosity to get it to cooperate.

Are we good now to tag it all for 2.7.1 on WP?

I'm going to download 2.7.1 from GH now and check it out.

What's the process going to be?

[Rumperuu]

The GitHub release failed - the fix (I'm hoping) is in #127

Best to download the ‘Development Version’ (== trunk/) archive from the SVN here.

Once we're happy that everything is working fine, it should just be a case of changing the ‘Stable Tag’ field in trunk/readme.txt to 2.7.1. Then the Plugin Directory will automatically parse it, copy the contents of trunk/ to tags/2.7.1/ and tell the users that there is a new update available.

There's no rush though; the milestone due date isn't until Friday, so we can leave it sat in trunk/ until then in case we come up with any more bugfixes between now and then that we can then roll into 2.7.1.

[Rumperuu]

GitHub release passed - archive available from https://github.com/markcheret/footnotes/releases/tag/2.7.1

I'm not really sure what the use case of having a release archive here as well as on the SVN repo. actually is, but it's definitely neat

[markcheret]

An off-platform backup is always neat. Wish I'd known that like 10 years ago. I lost 3 whole self-produced podcasts (40 episodes each) to ignorance of the aforementioned neatness.

[lolzim]

On my main WP site, it's still 2.7.0 and no new release available; normal?

[Rumperuu]

How are you viewing that screen? If I install the Plugin as a .zip I just see this, no mention of WP/PHP versions:

[lolzim]

Hi,

Here's the path:

Plugin add

Upload

Choose zip

Install

and then:

cu

[Rumperuu]

How strange, here is me doing the exact same steps (and using the .zip from the ‘Development Version’ selector on the WP Plugin Directory);

Do you have another Plugin that shows pre-install info on new Plugins running, or anything like that?

[lolzim]

This blog does have the plugin before uploading the zip file? It seems not, and it is the case on my.
Here's the full view:

(NB: as the plugin is already installed, it asks if this zip should replace the existing one)

And no, no other plugin in this WP dedicated to fn tests:

[Rumperuu]

That was it - I didn't have it installed so I wasn't seeing that screen (which seems pretty obvious in retrospect 😞)

Should be fixed in #139

[Rumperuu]

2.7.1 is now out on the SVN repo: https://plugins.svn.wordpress.org/footnotes/trunk/

In theory, at some point it will parse the new Stable Tag in trunk/readme.txt and automatically create a new tag. Fingers crossed.

[markcheret]

that would be new to me. In the past I always had to push a copy of the stable trunk to the desired tags folder.

[Rumperuu]

Ah yeah you're right, I misinterpreted what had happened in #55 (I think Pew made the tag, but I thought it was because the Plugin Directory had parsed the trunk/readme.txt and done it automatically). I've copied the 2.7.1 tag now.

[markcheret]

Congratulations team, this feels like the biggest release yet!
I'm very happy the process works and we had an orderly release.
I'm in party mode right now and will BBQ a steak with fries and open a cold brew in your honour.

[Rumperuu]

Spoke too soon 😭

The entire stylesheet build process is a complete mess. There are also some new AMP-related ones that have snuck into the css/ dir without being added to the build process (presumably at some point during the game of musical repos).

I've reverted the Stable Tag to 2.7.0, which should stop people who haven't already done so from being prompted to upgrade the Plugin. I'm not sure if people who have upgraded will be prompted to downgrade or not.

Pausing all releases until I've have a chance to do #134 (at least), which should be this weekend.

[markcheret]

there will be no downgrade option provided

[Rumperuu]

Following @pewgeuges's comment, I've checked and yes the .footnotes_table caption.accessibility CSS rule has been included in the minified stylesheets since 2.6.0, up until 2.7.1.

The issue appears to be that copies of (some of) the minified stylesheets in css/tmp/ are being tracked, and that these files are a month old (i.e., presumably just predating 2.6.0) and do not include the .footnotes_table caption.accessibility (nor, presumably, any of the other stylesheet-related fixes introduced since 2.6.0). gitignore is correctly set to ignore any tmp/ directories, but I guess that doesn't apply to files that are already set to be tracked. At some point in the release process, they must have overridden the newly-generated concatenated + minified stylesheets.

Downgrading to 2.7.0 will solve any issues (I've checked and the 2.7.0 stylesheets are definitely up-to-date on the SVN repo.), and I'm going to stand by my comment about not releasing anything else until I've be able to take full stock of just what on Earth is going on in that css/ directory.

[markcheret]

OK. Thanks for that. Also, I guess the SVN stuff is an animal of its own. We might need to purge everything before committing and making SVN believe all is new.

[Rumperuu]

Post-mortem discussion in #158