[Enhancement] Add text descriptions to proposals/history

[aguillon]

The History page in its current form is very good (I don't remember seeing it when I used the dApp the first time). I totally understand why I would need to go back in time to understand what was voted in my absence.

However, for less technical people, I think having the opportunity to add short descriptions of every past action would be nice: "deposit X amount of token", "send X money to Alex", "place X into Youves vault"…. I would argue that these messages do not need to be stored on the blockchain (and actually probably shouldn't, for privacy reasons).

[rueshyna]

This was discussed before with @tj825 and @oteku.
https://tezos-dev.slack.com/archives/C035HVC4NM9/p1675458069456449

• The argument is that the short descriptions may not reflect what transaction really want to do. Alice may leave Bob that we transfer 10Tez to her but actually it was 1000Tez.
• For advance users, if they make lambda proposal, we actually provide a "metadata" field for them to write anything they want. However, currently making lambda proposal doesn't support on UI but showing lambda proposal is ok. UI was making lambda proposal before but the finally decision was to remove it.

[aguillon]

That's an interesting discussion, thank you for pointing it out. I think it does not affect the history page, though: while I agree with @tj825 that malicious metadata can be used by an adversarial user, giving an opportunity for the members of a multisig to label past transactions should not be as harmful.

Also, I still don't think such labeling should be stored on the blockchain.

[rueshyna]

I guess I'm a bit confused about label you mention.
Do you mean a general description for user to see what proposals are, as the second column of picture shows?

or do you mean that let user make its own note, only for itself? In this case, maybe store data on the local of browser.

[aguillon]

Oh sorry, I forgot about this issue.

I mean useful, intelligible text for every users to see (so not in local storage). Let's say that I manage a safe with a few friends. We use the money to pay for parties that we throw out at one another's house. In retrospect (a few months after throwing a few parties), I want to be able to remember which action on TzSafe was for what party, i.e. have "Transfer 100 tez" with "Birthday party at Mark's house".

[rueshyna]

Sorry, too. I realized that I forgot clicking comment button...
If we don't that message on stores on-chain neither local storage, where should we store it?
I'm not sure we(Marigold) stores is a good idea 🤔 .