When a rebase happened, the "needs rebase" comment is removed along with the label, because it isn't needed anymore. Code:
|
if !dry_run { |
|
issues_api |
|
.remove_label(pull.number, &config.needs_rebase_label) |
|
.await?; |
|
for c in comments { |
|
issues_api.delete_comment(c.id).await?; |
|
} |
|
} |
Similarly, it would be nice to hide a "ci failed" comment along with removing the label. Code:
|
println!("... {} remove label '{}')", pull_number, ci_failed_label); |
|
if !ctx.dry_run { |
|
issues_api |
|
.remove_label(pull_number, &ci_failed_label) |
|
.await?; |
|
} |
The reason to hide it instead of removing it would be to leave the context around CI failures in the comment history, as it may be useful later on to learn why a code change was pushed.
When a rebase happened, the "needs rebase" comment is removed along with the label, because it isn't needed anymore. Code:
DrahtBot/stale/src/main.rs
Lines 266 to 273 in 07f7828
Similarly, it would be nice to hide a "ci failed" comment along with removing the label. Code:
DrahtBot/webhook_features/src/features/ci_status.rs
Lines 115 to 120 in 07f7828
The reason to hide it instead of removing it would be to leave the context around CI failures in the comment history, as it may be useful later on to learn why a code change was pushed.