draft: SampleHandlerBase becomes CRTP over event data type#866
Draft
luketpickering wants to merge 1 commit into
Draft
draft: SampleHandlerBase becomes CRTP over event data type#866luketpickering wants to merge 1 commit into
luketpickering wants to merge 1 commit into
Conversation
SampleHandlerBase -> template <class EventDataType> SampleHandlerBase_t<EventDataType> now: ``` using SampleHandlerBase = SampleHandlerBase_t<EventInfo>; ``` to hopefully not be a breaking change, classes inheriting from SampleHandlerBase will function exactly as before, but now subclasses are able to inject their event data type into the base class. All generic access to SampleHandlers must go through SampleHandlerInterface as SampleHandlerBase_t is no longer a class.
|
Hi @luketpickering, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
|
Hi, I am MaCh3-Telemetry bot Memory and CPU Usage SummaryMemory Usage PlotYou can view the memory usage plot directly in the job summary from the link above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SampleHandlerBase
-> template SampleHandlerBase_t
now:
to hopefully not be a breaking change, classes inheriting from SampleHandlerBase will function exactly as before, but now subclasses are able to inject their event data type into the base class.
All generic access to SampleHandlers must go through SampleHandlerInterface as SampleHandlerBase_t is no longer a class.
Pull request description
Changes or fixes
Examples