fix(website): use consistent checkbox css in search filters#6495
Open
corneliusroemer wants to merge 1 commit into
Open
fix(website): use consistent checkbox css in search filters#6495corneliusroemer wants to merge 1 commit into
corneliusroemer wants to merge 1 commit into
Conversation
We used different css for segment filters and strictness checkbox. The checkbox was the only one to use DaisyUI CSS classes. Replacing with the standard pattern we use for checkboxes across search UI. Tested locally: no more jumping, consistent look. Resolves #6483
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Search UI’s “strict” checkbox styling in the date range filter to match the Tailwind-based checkbox pattern used elsewhere, addressing the reported “jumping”/inconsistent appearance on page load (Issue #6483).
Changes:
- Replaced the DateRangeField strictness checkbox’s DaisyUI classes with the standard Tailwind checkbox classes used in other SearchPage components.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
121
to
125
| <span className='text-gray-400 text-sm mr-2'>strict</span> | ||
| <input | ||
| type='checkbox' | ||
| className='checkbox checkbox-sm text-3xl [--chkbg:white] [--chkfg:theme(colors.gray.700)] checked:border-gray-300' | ||
| className='h-4 w-4 rounded border-gray-300 text-primary-600 focus:ring-primary-600 cursor-pointer' | ||
| checked={strictMode} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used different css for segment filters and strictness checkbox.
The checkbox was the only one to use DaisyUI CSS classes. Replacing with the standard pattern we use for checkboxes across search UI.
Tested locally: no more jumping, consistent look.
Resolves #6483
Screenshots
Before:
After:
🚀 Preview: https://unify-checkbox-css.loculus.org