Attribute priority: first wins

[bcardarella]

Accoridng to the HTML spec when it comes to duplicate attributes the first defined attribute is the one that wins. Subsequent attributes of the same name are ignored:

I just want to confirm that we are adhering to this as well in the SwiftUI client.

[carson-katri]

Core is used to fetch attributes by name with the getAttribute function on Node, so I think this issue should be moved there.

[mobile-bungalow]

It seems that get_attribute already returns the first.

There are specific cases where the last one is used. csrf tokens being the most important example. Should we consider taking the first of those?

[bcardarella]

do you have examples of documents that have multiple csrf tokens inline?

[mobile-bungalow]

I have none. I can dig through the commit history to see if there is a spelled out justification for that, but my intuition tells me that if you have multiple CSRF tokens something has gone terribly wrong.

[bcardarella]

I agree, I cannot think of a scenario where there would be multiple tokens rendered. But let's ask Chris today on our call

[mobile-bungalow]

Yeah, sounds good, if there aren't any concrete instances of attributes showing up with the wrong precedence i'm going to vote to close this issue.