From 08bb2d0fdf34e3a520bee1cb9e4fec8d2887d0b4 Mon Sep 17 00:00:00 2001 From: SaiChand440 Date: Tue, 4 Mar 2025 14:01:50 +0530 Subject: [PATCH 1/2] setting up proper typecast for other variables --- ios/LiveKitReactNativeModule.swift | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ios/LiveKitReactNativeModule.swift b/ios/LiveKitReactNativeModule.swift index 50b68ebe..8a52e06b 100644 --- a/ios/LiveKitReactNativeModule.swift +++ b/ios/LiveKitReactNativeModule.swift @@ -199,9 +199,9 @@ public class LivekitReactNativeModule: RCTEventEmitter { @objc(createMultibandVolumeProcessor:pcId:trackId:) public func createMultibandVolumeProcessor(_ options: NSDictionary, pcId: NSNumber, trackId: String) -> String { let bands = (options["bands"] as? NSNumber)?.intValue ?? 5 - let minFrequency = (options["minFrequency"] as? NSString)?.floatValue ?? 1000 - let maxFrequency = (options["maxFrequency"] as? NSString)?.floatValue ?? 8000 - let intervalMs = (options["updateInterval"] as? NSString)?.floatValue ?? 40 + let minFrequency = (options["minFrequency"] as? NSNumber)?.floatValue ?? 1000 + let maxFrequency = (options["maxFrequency"] as? NSNumber)?.floatValue ?? 8000 + let intervalMs = (options["updateInterval"] as? NSNumber)?.floatValue ?? 40 let renderer = MultibandVolumeAudioRenderer( bands: bands, From 0af7ca5f43aae5118d1d207d1c6af55b151cbef8 Mon Sep 17 00:00:00 2001 From: SaiChand440 Date: Tue, 4 Mar 2025 14:06:01 +0530 Subject: [PATCH 2/2] move actions to v4 as v2 is depreceated --- .github/workflows/native_build.yaml | 6 +++--- .github/workflows/test.yaml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/native_build.yaml b/.github/workflows/native_build.yaml index 408cf15b..072fc853 100644 --- a/.github/workflows/native_build.yaml +++ b/.github/workflows/native_build.yaml @@ -27,7 +27,7 @@ jobs: cache: 'yarn' cache-dependency-path: '**/yarn.lock' - - uses: actions/cache@v2 + - uses: actions/cache@v4 with: path: | ~/.npm @@ -63,7 +63,7 @@ jobs: cache: 'yarn' cache-dependency-path: '**/yarn.lock' - - uses: actions/cache@v2 + - uses: actions/cache@v4 with: path: | ~/.npm @@ -75,7 +75,7 @@ jobs: ${{ runner.os }}-node- - name: Cache cocoapods - uses: actions/cache@v2 + uses: actions/cache@v4 with: path: ./ci/ios/Pods key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }} diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index b1811b0d..53d4755e 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -19,7 +19,7 @@ jobs: with: node-version: '18.x' - - uses: actions/cache@v2 + - uses: actions/cache@v4 with: path: | ~/.npm