fs: Fix lock leak in replace_fd()#1441
Open
vfsci-bot[bot] wants to merge 1 commit into
Open
Conversation
In replace_fd(), the function acquires files->file_lock but then has two return paths that don't release the lock: - When do_dup2() fails (returns negative error) - When do_dup2() succeeds (returns 0) Both of these paths return directly without unlocking files->file_lock, causing a lock leak and potential deadlock. Fix this by making both error and success paths go through the out_unlock label to ensure the lock is always released. Fixes: 708c04a ("fs: always return zero on success from replace_fd()") Cc: stable@vger.kernel.org Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series: https://patchwork.kernel.org/project/linux-fsdevel/list/?series=1098526
Submitter: Hongling Zeng
Version: 1
Patches: 1/1
Message-ID:
<20260521074934.49256-1-zenghongling@kylinos.cn>Base: vfs.base.ci
Lore: https://lore.kernel.org/linux-fsdevel/20260521074934.49256-1-zenghongling@kylinos.cn
Automated by ml2pr