From 145d2ac79880ccec45af28d7ac4357198c00ff41 Mon Sep 17 00:00:00 2001 From: Sahitya Chandra Date: Fri, 15 May 2026 14:41:35 +0530 Subject: [PATCH] fix: pass NodeList to processAllNodesForRule in tests processAllNodesForRule now takes a *corev1.NodeList, but two tests still called it with the old two-argument signature, breaking the build on main. Pass a NodeList through, matching the production caller. Signed-off-by: Sahitya Chandra --- internal/controller/nodereadinessrule_controller_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/controller/nodereadinessrule_controller_test.go b/internal/controller/nodereadinessrule_controller_test.go index 3daa5fe..a1e02a6 100644 --- a/internal/controller/nodereadinessrule_controller_test.go +++ b/internal/controller/nodereadinessrule_controller_test.go @@ -1878,7 +1878,8 @@ var _ = Describe("NodeReadinessRule Controller", func() { EventRecorder: record.NewFakeRecorder(10), } - Expect(failController.processAllNodesForRule(ctx, rule)).To(Succeed()) + nodeList := &corev1.NodeList{Items: []corev1.Node{*failNode}} + Expect(failController.processAllNodesForRule(ctx, rule, nodeList)).To(Succeed()) Expect(rule.Status.AppliedNodes).NotTo(ContainElement("fail-path-node")) @@ -1934,7 +1935,8 @@ var _ = Describe("NodeReadinessRule Controller", func() { EventRecorder: record.NewFakeRecorder(10), } - Expect(successController.processAllNodesForRule(ctx, rule)).To(Succeed()) + nodeList := &corev1.NodeList{Items: []corev1.Node{*successNode}} + Expect(successController.processAllNodesForRule(ctx, rule, nodeList)).To(Succeed()) Expect(rule.Status.AppliedNodes).To(ContainElement("stale-recovery-node"))