Fix markdown title removal in parseMarkdownFile (#21)

* Initial plan

* Fix markdown title removal bug - preserve first line when no frontmatter

Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>

* Address code review comments - improve comment grammar and variable scope

Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>

* Remove unnecessary empty file check as suggested in review

Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>

* Refactor to use single scan loop with state machine

Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Co-authored-by: Alex Collins <alexec@users.noreply.github.com>

Author: Copilot

markdown.go

@@ -20,32 +20,50 @@ func parseMarkdownFile(path string, frontmatter any) (string, error) {
 
 	s := bufio.NewScanner(fh)
 
-	if s.Scan() && s.Text() == "---" {
-		var frontMatterBytes bytes.Buffer
-		for s.Scan() {
-			line := s.Text()
+	var content bytes.Buffer
+	var frontMatterBytes bytes.Buffer
+	
+	// State machine: 0 = unknown, 1 = scanning frontmatter, 2 = scanning content
+	state := 0
+	
+	for s.Scan() {
+		line := s.Text()
+		
+		switch state {
+		case 0: // State unknown - first line
 			if line == "---" {
-				break
+				state = 1 // Start scanning frontmatter
+			} else {
+				state = 2 // No frontmatter, start scanning content
+				if _, err := content.WriteString(line + "\n"); err != nil {
+					return "", fmt.Errorf("failed to write content: %w", err)
+				}
 			}
-
-			if _, err := frontMatterBytes.WriteString(line + "\n"); err != nil {
-				return "", fmt.Errorf("failed to write frontmatter: %w", err)
+		case 1: // Scanning frontmatter
+			if line == "---" {
+				state = 2 // End of frontmatter, start scanning content
+			} else {
+				if _, err := frontMatterBytes.WriteString(line + "\n"); err != nil {
+					return "", fmt.Errorf("failed to write frontmatter: %w", err)
+				}
+			}
+		case 2: // Scanning content
+			if _, err := content.WriteString(line + "\n"); err != nil {
+				return "", fmt.Errorf("failed to write content: %w", err)
 			}
-		}
-
-		if err := yaml.Unmarshal(frontMatterBytes.Bytes(), frontmatter); err != nil {
-			return "", fmt.Errorf("failed to unmarshal frontmatter: %w", err)
-		}
-	}
-
-	var content bytes.Buffer
-	for s.Scan() {
-		if _, err := content.WriteString(s.Text() + "\n"); err != nil {
-			return "", fmt.Errorf("failed to write content: %w", err)
 		}
 	}
+	
 	if err := s.Err(); err != nil {
 		return "", fmt.Errorf("failed to scan file: %w", err)
 	}
+	
+	// Parse frontmatter if we collected any
+	if frontMatterBytes.Len() > 0 {
+		if err := yaml.Unmarshal(frontMatterBytes.Bytes(), frontmatter); err != nil {
+			return "", fmt.Errorf("failed to unmarshal frontmatter: %w", err)
+		}
+	}
+	
 	return content.String(), nil
 }

markdown_test.go

@@ -35,7 +35,17 @@ of the markdown file.
 			content: `This is a simple markdown file
 without any frontmatter.
 `,
-			wantContent: "without any frontmatter.\n",
+			wantContent: "This is a simple markdown file\nwithout any frontmatter.\n",
+			wantFrontmatter: map[string]string{},
+			wantErr: false,
+		},
+		{
+			name: "markdown with title as first line",
+			content: `# My Title
+
+This is the content.
+`,
+			wantContent: "# My Title\n\nThis is the content.\n",
 			wantFrontmatter: map[string]string{},
 			wantErr: false,
 		},