From acf8798f3024c59715a411017cf9d1f2c09bb9b4 Mon Sep 17 00:00:00 2001 From: Diogo Silva Date: Thu, 7 May 2026 17:27:40 +0100 Subject: [PATCH] fix(router-modules): bump peer @modular-react/* to 2.x range MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `@tanstack-react-modules/*` and `@react-router-modules/*` packages still declare `@modular-react/core: ^1.2.0` (and `react: ^1.2.0` on runtime/ testing) in their peer ranges, even though the actual code in those runtimes consumes the React Context produced by `@modular-react/react@2.x` in the host's `` tree. When a consumer installs `@modular-react/core@^2.0.0` alongside, npm hoists 2.x for the host but nests `core@1.x` + `react@1.x` under each router-modules package — two copies of `@modular-react/react` means two distinct React Context objects, and `useZones` / `useNavigation` / `useRouteData` silently return undefined because the consumer reads the wrong context. Same peer-descriptor correction we did for journeys/react in #33, applied to all six router-modules packages. Testing packages also bump their peer of `@modular-react/journeys` from `^1.0.0` to `^1.0.1` to match the upstream peer correction. No behavior change. --- CHANGELOG.md | 1 + packages/react-router-core/package.json | 2 +- packages/react-router-runtime/package.json | 4 ++-- packages/react-router-testing/package.json | 6 +++--- packages/tanstack-router-core/package.json | 2 +- packages/tanstack-router-runtime/package.json | 4 ++-- packages/tanstack-router-testing/package.json | 6 +++--- 7 files changed, 13 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4539e7c..de02bd8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ Per-package detail lives in the GitHub release tagged `@`. ### Peer-dep ranges - **`@modular-react/react`** and **`@modular-react/journeys`** — peer ranges for `@modular-react/core` (and, for journeys, `@modular-react/react`) bumped from `^1.2.0` to `^2.0.0` to match the packages' actual release lines. Drift went unnoticed when `@modular-react/react@2.0.0` and `@modular-react/journeys@1.0.0` shipped: both packages already require a 2.x core at runtime (lazy entry-point support, `EagerModuleEntryPoint | LazyModuleEntryPoint` discriminated union, `resolveEntryComponent` with sync-thenable fast path), but the peer descriptors still pointed at 1.x. Consumers installing `journeys@1.0.0` against `core@^2.0.0` get an `ERESOLVE` error from npm, and `--legacy-peer-deps` workarounds end up dual-installing core (one hoisted 2.x copy plus a nested 1.x copy under journeys), which fragments singletons (`registry`, `defineEntry` identity) at runtime. This is a peer-descriptor correction, not a behavior change. +- **`@tanstack-react-modules/core`**, **`@tanstack-react-modules/runtime`**, **`@tanstack-react-modules/testing`**, **`@react-router-modules/core`**, **`@react-router-modules/runtime`**, **`@react-router-modules/testing`** — same peer-range correction: `@modular-react/core` and `@modular-react/react` bumped from `^1.2.0` to `^2.0.0`; testing packages' peer of `@modular-react/journeys` bumped from `^1.0.0` to `^1.0.1` to match the corrected upstream. Same drift cause and same consumer impact as the previous entry — without this fix, runtime packages nest a 1.x core under a 2.x host, which breaks React Context identity for `useZones` / `useNavigation` / `useRouteData` (the runtime hooks consume contexts created by `@modular-react/react` in the host's `` tree). Peer-descriptor correction only. ## 2026-04-19 — `@modular-react/*@1.2.0`, `@*-modules/*@2.3.0` diff --git a/packages/react-router-core/package.json b/packages/react-router-core/package.json index 01ea1d6..cb01444 100644 --- a/packages/react-router-core/package.json +++ b/packages/react-router-core/package.json @@ -40,7 +40,7 @@ "zustand": "^5.0.0" }, "peerDependencies": { - "@modular-react/core": "^1.2.0", + "@modular-react/core": "^2.0.0", "react": "^19.0.0", "react-router": "^7.6.0", "zustand": "^5.0.0" diff --git a/packages/react-router-runtime/package.json b/packages/react-router-runtime/package.json index 73bc8fe..51c7b66 100644 --- a/packages/react-router-runtime/package.json +++ b/packages/react-router-runtime/package.json @@ -47,8 +47,8 @@ "zustand": "^5.0.0" }, "peerDependencies": { - "@modular-react/core": "^1.2.0", - "@modular-react/react": "^1.2.0", + "@modular-react/core": "^2.0.0", + "@modular-react/react": "^2.0.0", "@react-router-modules/core": "^2.3.0", "react": "^19.0.0", "react-dom": "^19.0.0", diff --git a/packages/react-router-testing/package.json b/packages/react-router-testing/package.json index bdfbe25..7d428f2 100644 --- a/packages/react-router-testing/package.json +++ b/packages/react-router-testing/package.json @@ -47,9 +47,9 @@ "zustand": "^5.0.0" }, "peerDependencies": { - "@modular-react/core": "^1.2.0", - "@modular-react/journeys": "^1.0.0", - "@modular-react/react": "^1.2.0", + "@modular-react/core": "^2.0.0", + "@modular-react/journeys": "^1.0.1", + "@modular-react/react": "^2.0.0", "@react-router-modules/core": "^2.3.0", "@react-router-modules/runtime": "^2.3.0", "@testing-library/react": "^16.0.0", diff --git a/packages/tanstack-router-core/package.json b/packages/tanstack-router-core/package.json index a5c6a01..43bc54d 100644 --- a/packages/tanstack-router-core/package.json +++ b/packages/tanstack-router-core/package.json @@ -40,7 +40,7 @@ "zustand": "^5.0.0" }, "peerDependencies": { - "@modular-react/core": "^1.2.0", + "@modular-react/core": "^2.0.0", "@tanstack/react-router": "^1.168.8", "react": "^19.0.0", "zustand": "^5.0.0" diff --git a/packages/tanstack-router-runtime/package.json b/packages/tanstack-router-runtime/package.json index 11e92a4..ff497cb 100644 --- a/packages/tanstack-router-runtime/package.json +++ b/packages/tanstack-router-runtime/package.json @@ -47,8 +47,8 @@ "zustand": "^5.0.0" }, "peerDependencies": { - "@modular-react/core": "^1.2.0", - "@modular-react/react": "^1.2.0", + "@modular-react/core": "^2.0.0", + "@modular-react/react": "^2.0.0", "@tanstack-react-modules/core": "^2.3.0", "@tanstack/react-router": "^1.168.8", "react": "^19.0.0", diff --git a/packages/tanstack-router-testing/package.json b/packages/tanstack-router-testing/package.json index ceb92c2..5ab7fc5 100644 --- a/packages/tanstack-router-testing/package.json +++ b/packages/tanstack-router-testing/package.json @@ -47,9 +47,9 @@ "zustand": "^5.0.0" }, "peerDependencies": { - "@modular-react/core": "^1.2.0", - "@modular-react/journeys": "^1.0.0", - "@modular-react/react": "^1.2.0", + "@modular-react/core": "^2.0.0", + "@modular-react/journeys": "^1.0.1", + "@modular-react/react": "^2.0.0", "@tanstack-react-modules/core": "^2.3.0", "@tanstack-react-modules/runtime": "^2.3.0", "@tanstack/react-router": "^1.168.8",