Commit da1c511
authored
Remove -y flag from browsers delete, make non-interactive (#85)
## Summary
- Remove the `-y/--yes` confirmation flag from `kernel browsers delete`
- Make browser deletion non-interactive by default
The confirmation prompt was overly cautious and not necessary:
1. **LLM compatibility**: The `-y` flag frequently trips up LLMs that
use the CLI - they either forget to pass it or get stuck waiting for
interactive confirmation that never comes in their execution
environment.
2. **Idempotent operation**: Browser deletion is already idempotent
(deleting a non-existent browser succeeds), so requiring confirmation
adds friction without meaningful protection.
3. **Consistency**: Other delete commands in the CLI (like browser
session cleanup) don't require confirmation.
## Test plan
- [x] Existing browser delete tests updated and passing
- [x] `go build ./...` succeeds
- [x] Manual verification: `kernel browsers delete <id>` now deletes
without prompting
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Makes `kernel browsers delete` non-interactive and removes
confirmation flags.
>
> - Removes `-y/--yes` flag and all interactive confirmation logic from
`BrowsersCmd.Delete`; command is now idempotent and non-interactive
> - `Delete` now tries `DeleteByID` then persistent delete, treating
not-found as success; prints a single success message
> - Removes flag wiring and usage of `--yes` in CLI
(`runBrowsersDelete`) and README examples
> - Updates tests to match the new behavior and deletes confirm-path
test cases
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
5b74b84. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 55a2524 commit da1c511
3 files changed
Lines changed: 8 additions & 55 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | | - | |
217 | 216 | | |
218 | 217 | | |
219 | 218 | | |
| |||
519 | 518 | | |
520 | 519 | | |
521 | 520 | | |
522 | | - | |
| 521 | + | |
523 | 522 | | |
524 | 523 | | |
525 | 524 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
171 | | - | |
172 | | - | |
| 171 | + | |
173 | 172 | | |
174 | 173 | | |
175 | 174 | | |
| |||
406 | 405 | | |
407 | 406 | | |
408 | 407 | | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
438 | | - | |
439 | | - | |
440 | | - | |
441 | | - | |
| 408 | + | |
442 | 409 | | |
443 | 410 | | |
444 | 411 | | |
| |||
2145 | 2112 | | |
2146 | 2113 | | |
2147 | 2114 | | |
2148 | | - | |
2149 | | - | |
2150 | 2115 | | |
2151 | 2116 | | |
2152 | 2117 | | |
| |||
2305 | 2270 | | |
2306 | 2271 | | |
2307 | 2272 | | |
2308 | | - | |
2309 | 2273 | | |
2310 | 2274 | | |
2311 | 2275 | | |
2312 | 2276 | | |
2313 | 2277 | | |
2314 | | - | |
| 2278 | + | |
2315 | 2279 | | |
2316 | 2280 | | |
2317 | 2281 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
246 | | - | |
| 246 | + | |
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
258 | | - | |
| 258 | + | |
259 | 259 | | |
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
263 | 263 | | |
264 | | - | |
| 264 | + | |
265 | 265 | | |
266 | 266 | | |
267 | 267 | | |
| |||
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
276 | | - | |
| 276 | + | |
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
282 | 282 | | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | 283 | | |
294 | 284 | | |
295 | 285 | | |
| |||
0 commit comments