Skip to content

Incorrect check if body is a string #12

@udalrich

Description

@udalrich

The code checks if body is a string by doing if body.lower:. That passes if it is a string, but throws an exception if body is a io.BufferedReader, such as what one gets from

with open('someFile.bin', 'rb') as f:
  with boddle(body=f):
     pass

It would also fail if the file-like object happens to have a lower method/attribute

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions