fix(helm): use fullname in selector labels to prevent mismatch on upgrade (#47)

* fix(helm): use fullname in selector labels to prevent mismatch on upgrade

Use kagent.fullname instead of kagent.name in selectorLabels so that
changing nameOverride does not alter the app.kubernetes.io/name selector
label. Deployment spec.selector.matchLabels is immutable in Kubernetes,
so any label change causes a Service/Deployment selector mismatch after
helm upgrade, leaving the Service with zero endpoints.

With this fix, both the old config (fullnameOverride: kagent-tools) and
the new config (nameOverride: tools) resolve to the same fullname
"kagent-tools" for the default release name, keeping selectors stable
across upgrades.

Fixes kagent-dev/kagent#1427

Signed-off-by: Jaison Paul <paul.jaison@gmail.com>

* fix(e2e): update label selectors to match fullname-based selector labels

Update E2E tests to use app.kubernetes.io/instance label selector instead of
app.kubernetes.io/name since the PR changes selectorLabels to use kagent.fullname.

The fullname template returns the release name (kagent-tools-e2e), so the tests
now use app.kubernetes.io/instance=<releaseName> which remains stable and matches
the updated selector labels in the Helm chart.

This fixes the E2E test failures where pods weren't being found because the
label selector no longer matched after the selectorLabels change.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

---------

Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: 3 people

helm/kagent-tools/templates/_helpers.tpl

@@ -43,7 +43,7 @@ app.kubernetes.io/managed-by: {{ .Release.Service }}
 Selector labels
 */}}
 {{- define "kagent.selectorLabels" -}}
-app.kubernetes.io/name: {{ include "kagent.name" . }}
+app.kubernetes.io/name: {{ include "kagent.fullname" . }}
 app.kubernetes.io/instance: {{ .Release.Name }}
 {{- end }}
 

helm/kagent-tools/tests/deployment_test.yaml

@@ -171,5 +171,5 @@ tests:
       - equal:
           path: spec.template.spec.topologySpreadConstraints[0].labelSelector.matchLabels
           value:
-            app.kubernetes.io/name: kagent-tools
+            app.kubernetes.io/name: RELEASE-NAME
             app.kubernetes.io/instance: RELEASE-NAME

test/e2e/helpers_test.go

@@ -224,7 +224,7 @@ func InstallKAgentTools(namespace string, releaseName string) {
 		defer cancel()
 
 		output, err := commands.NewCommandBuilder("kubectl").
-			WithArgs("get", "pods", "-n", namespace, "-l", "app.kubernetes.io/name=kagent-tools", "-o", "jsonpath={.items[*].status.phase}").
+			WithArgs("get", "pods", "-n", namespace, "-l", "app.kubernetes.io/instance="+releaseName, "-o", "jsonpath={.items[*].status.phase}").
 			Execute(ctx)
 
 		if err != nil {

test/e2e/k8s_test.go

@@ -56,7 +56,7 @@ var _ = Describe("KAgent Tools Kubernetes E2E Tests", Ordered, func() {
 
 			log.Info("Checking if kagent-tools pods are running", "namespace", namespace)
 			output, err := commands.NewCommandBuilder("kubectl").
-				WithArgs("get", "pods", "-n", namespace, "-l", "app.kubernetes.io/name=kagent-tools", "-o", "json").
+				WithArgs("get", "pods", "-n", namespace, "-l", "app.kubernetes.io/instance="+releaseName, "-o", "json").
 				Execute(ctx)
 
 			Expect(err).ToNot(HaveOccurred())
@@ -70,7 +70,7 @@ var _ = Describe("KAgent Tools Kubernetes E2E Tests", Ordered, func() {
 
 			log.Info("Checking if kagent-tools service is accessible", "namespace", namespace)
 			output, err := commands.NewCommandBuilder("kubectl").
-				WithArgs("get", "svc", "-n", namespace, "-l", "app.kubernetes.io/name=kagent-tools", "-o", "json").
+				WithArgs("get", "svc", "-n", namespace, "-l", "app.kubernetes.io/instance="+releaseName, "-o", "json").
 				Execute(ctx)
 
 			Expect(err).ToNot(HaveOccurred())