Skip to content

Commit af9d36f

Browse files
authored
Merge pull request #119 from julwrites/staging
Fix for GCLOUD_PROJECT_ID
2 parents ae5d701 + cabe85a commit af9d36f

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

.github/workflows/deployment.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,22 +43,22 @@ jobs:
4343
env:
4444
TELEGRAM_ID: ${{secrets.TELEGRAM_ID}}
4545
ADMIN_ID: ${{secrets.TELEGRAM_ADMIN_ID}}
46-
PROJECT_ID: ${{secrets.GCLOUD_PROJECT_ID}}
46+
GCLOUD_PROJECT_ID: ${{secrets.GCLOUD_PROJECT_ID}}
4747
ARTIFACT_ID: ${{secrets.GCLOUD_ARTIFACT_REPOSITORY_ID}}
4848
run: |
49-
printf "TELEGRAM_ID: \"$TELEGRAM_ID\"\nADMIN_ID: \"$ADMIN_ID\"\nPROJECT_ID: \"$PROJECT_ID\"\n" >> secrets.yaml
49+
printf "TELEGRAM_ID: \"$TELEGRAM_ID\"\nADMIN_ID: \"$ADMIN_ID\"\nGCLOUD_PROJECT_ID: \"$GCLOUD_PROJECT_ID\"\n" >> secrets.yaml
5050
cat secrets.yaml
51-
docker build -f Dockerfile -t ${{ secrets.GCLOUD_REGION }}-docker.pkg.dev/$PROJECT_ID/$ARTIFACT_ID/root:latest .
52-
docker push ${{ secrets.GCLOUD_REGION }}-docker.pkg.dev/$PROJECT_ID/$ARTIFACT_ID/root:latest
51+
docker build -f Dockerfile -t ${{ secrets.GCLOUD_REGION }}-docker.pkg.dev/$GCLOUD_PROJECT_ID/$ARTIFACT_ID/root:latest .
52+
docker push ${{ secrets.GCLOUD_REGION }}-docker.pkg.dev/$GCLOUD_PROJECT_ID/$ARTIFACT_ID/root:latest
5353
5454
- name: Deployment
5555
env:
56-
PROJECT_ID: ${{secrets.GCLOUD_PROJECT_ID}}
56+
GCLOUD_PROJECT_ID: ${{secrets.GCLOUD_PROJECT_ID}}
5757
ARTIFACT_ID: ${{secrets.GCLOUD_ARTIFACT_REPOSITORY_ID}}
5858
APPLICATION_CREDENTIALS: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }}
5959
TELEGRAM_ID: ${{secrets.TELEGRAM_ID}}
6060
run: |
61-
gcloud run deploy scripturebot --image ${{ secrets.GCLOUD_REGION }}-docker.pkg.dev/$PROJECT_ID/$ARTIFACT_ID/root:latest --region ${{ secrets.GCLOUD_REGION }} --allow-unauthenticated
61+
gcloud run deploy scripturebot --image ${{ secrets.GCLOUD_REGION }}-docker.pkg.dev/$GCLOUD_PROJECT_ID/$ARTIFACT_ID/root:latest --region ${{ secrets.GCLOUD_REGION }} --allow-unauthenticated
6262
SERVICE_URL=$(gcloud run services describe scripturebot --region ${{ secrets.GCLOUD_REGION }} --format 'value(status.url)')
6363
echo "Setting webhook for $SERVICE_URL"
6464
go run cmd/webhook/main.go -url "$SERVICE_URL"

MIGRATION.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ gcloud auth application-default login
4848
Run the export command against the **Source Project**.
4949

5050
```bash
51-
go run cmd/migrate/main.go -mode export -project <SOURCE_PROJECT_ID> -file backup_users.json
51+
go run cmd/migrate/main.go -mode export -gcloud_project_id <SOURCE_GCLOUD_PROJECT_ID> -file backup_users.json
5252
```
5353
* This will fetch all users and save them to `backup_users.json`.
5454
* Review the file to ensure data looks correct.
@@ -57,7 +57,7 @@ go run cmd/migrate/main.go -mode export -project <SOURCE_PROJECT_ID> -file backu
5757
Run the import command against the **Destination Project**.
5858

5959
```bash
60-
go run cmd/migrate/main.go -mode import -project <DESTINATION_PROJECT_ID> -file backup_users.json
60+
go run cmd/migrate/main.go -mode import -gcloud_project_id <DESTINATION_GCLOUD_PROJECT_ID> -file backup_users.json
6161
```
6262
* This will read `backup_users.json` and upload each user to the new Datastore.
6363
* **Note**: Ensure the Destination Project has Datastore (Firestore in Datastore mode) enabled.

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,11 @@ As such it requires [gcloud CLI](https://cloud.google.com/sdk/docs/quickstart) t
6161
The artifact repository is set to `us-central1`
6262

6363
As such the docker container can be built using the following command
64-
`docker build -f Dockerfile -t us-central1-docker.pkg.dev/${PROJECT_ID}/scripturebot/root:latest .`
64+
`docker build -f Dockerfile -t us-central1-docker.pkg.dev/${GCLOUD_PROJECT_ID}/scripturebot/root:latest .`
6565

6666
And then uploaded using
6767

68-
`docker push docker build -f Dockerfile -t us-central1-docker.pkg.dev/${PROJECT_ID}/scripturebot/root:latest .`
68+
`docker push us-central1-docker.pkg.dev/${GCLOUD_PROJECT_ID}/scripturebot/root:latest`
6969

7070
And finally deployed using
71-
`gcloud run deploy scripturebot --image us-central1-docker.pkg.dev/${PROJECT_ID}/scripturebot/root:latest --region us-central1`
71+
`gcloud run deploy scripturebot --image us-central1-docker.pkg.dev/${GCLOUD_PROJECT_ID}/scripturebot/root:latest --region us-central1`

cmd/migrate/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ import (
1515

1616
func main() {
1717
mode := flag.String("mode", "", "Mode of operation: 'export' or 'import'")
18-
project := flag.String("project", "", "Google Cloud Project ID")
18+
project := flag.String("gcloud_project_id", "", "Google Cloud Project ID")
1919
file := flag.String("file", "users.json", "Path to the JSON file for export/import")
2020

2121
flag.Parse()
2222

2323
if *mode == "" || *project == "" {
24-
fmt.Println("Usage: go run cmd/migrate/main.go -mode [export|import] -project [PROJECT_ID] -file [FILENAME]")
24+
fmt.Println("Usage: go run cmd/migrate/main.go -mode [export|import] -gcloud_project_id [GCLOUD_PROJECT_ID] -file [FILENAME]")
2525
flag.PrintDefaults()
2626
os.Exit(1)
2727
}

0 commit comments

Comments
 (0)