URL.setProtocol doesn't

[hjellinek]

Hi Julius,
urlplus has saved me some work. Thanks for writing it.

I discovered that the setProtocol method doesn't actually change 'this.' I fixed it in my copy:

public URL setProtocol(String protocol) throws IllegalArgumentException {
this.protocol = Protocol.valueOf(protocol.toLowerCase());
return this;
}

and I've added a unit test. I also fixed a couple of JavaDoc errors. Would you like me to send you my changes?

[juliuss]

Hi, that would be great!

Sorry about the slow response.

I'm about to fix an issue I found with changing a URL's hash as well.

[hjellinek]

Hi,
I modified com.shopobot.util.URLTest (which I moved to package
com.shopobot.util.tests -- please ignore that package change and the
changes to the imports I had to make to accommodate it) and
com.shopobot.util.URL. The files are attached.
Thanks for writing urlplus!

             Herb

On 11/12/13, 3:22 PM, Julius Schorzman wrote:

Hi, that would be great!

Sorry about the slow response.

I'm about to fix an issue I found with changing a URL's hash as well.