Package the license and repo with the plugin

[mr-thierry]

We cannot use this plugin internally because one of our tool flags it because the license is not packaged with the plugin.

For example check Dexcount Gradle Plugin. The license is properly packaged in the POM:

<licenses>
    <license>
        <name>The Apache Software License, Version 2.0</name>
        <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
        <distribution>repo</distribution>
    </license>
</licenses>

There is no license in the modules-graph-assert latest POM.

Similarly, the source repo should also be included. Again, for the dexcount-gradle-plugin it's:

<scm>
    <connection>scm:git:git://github.com/KeepSafe/dexcount-gradle-plugin.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/KeepSafe/dexcount-gradle-plugin.git</developerConnection>
    <url>https://github.com/KeepSafe/dexcount-gradle-plugin/</url>
</scm>

I think by just adding vacUrl in the gradlePlugin, the license and the repo URL will be picked up automatically. See https://github.com/KeepSafe/dexcount-gradle-plugin/blob/d17e9cf40fdb6bd8f9740f2900443a660ce932a7/build.gradle#L269C1-L269C13

[mr-thierry]

🤦 It's already present :
https://github.com/jraska/modules-graph-assert/blob/master/plugin/build.gradle#L38

[mr-thierry]

I'm not sure why this doesn't get picked up by the publishing task?

[brentwatson]

I think the following are missing from gradle.properties, which should resolve this:

POM_LICENCE_NAME=The Apache Software License, Version 2.0
POM_LICENCE_URL=http://www.apache.org/licenses/LICENSE-2.0.txt
POM_LICENCE_DIST=repo

[jraska]

Hey, thanks for raising the issue. Will fix that once I get to it.

[jraska]

Checking the latest POM, the licenses are still not there, therefore a different fix than #289 is required 🤔

[mr-thierry]

I have another PR that hopefully solves the issue 🤞

[jraska]

Still no luck :( POM

Thanks for the efforts, but I guess we would have to ask Gradle folks how to include these into the publication plugin.

[mr-thierry]

I'm closing this issue. I did a quick check in the plugin repo and it seems the vast majority of the plugin don't have license in their POM file. I'll see with our infrastructure team if we can use another way to enable this plugin internally.

Thank you for your time!

[StefMa]

Super strage, because I just run publishToMavenLocal on https://github.com/jraska/modules-graph-assert/tree/25fc15876e703e519a6b5a8330f26ef6888e09b1 and it seems the license is there:

Same for the other one: