Refactor React Native CI/CD workflow: streamline job definitions, update artifact handling, and enhance release creation process

Author: josharnow

.github/workflows/react-native-cicd.yml

@@ -1,3 +1,4 @@
+# Inspired by https://www.expobuilder.app
 name: React Native CI/CD
 
 on:
@@ -8,7 +9,6 @@ on:
   #       description: "Build type to run"
   #       options:
   #         - dev
-  #         - prod-apk
   #         - prod-aab
   #         - ios-dev
   #         - ios-prod
@@ -23,45 +23,36 @@ on:
   #         - android
   #         - ios
   #         - all
-    workflow_call:
-      secrets:
-        EXPO_TOKEN:
-          required: true
-        EXPO_APPLE_ID:
-          required: true
-        EXPO_APPLE_PASSWORD:
-          required: true
-        EXPO_TEAM_ID:
-          required: true
-        GOOGLE_PLAY_SERVICE_ACCOUNT:
-          required: false
-        SLACK_WEBHOOK:
-          required: false
-        DISCORD_WEBHOOK:
-          required: false
-        GITHUB_TOKEN:
-          required: true
+  workflow_call:
+    secrets:
+      EXPO_TOKEN:
+        required: true
+      EXPO_APPLE_ID:
+        required: true
+      EXPO_APPLE_PASSWORD:
+        required: true
+      EXPO_TEAM_ID:
+        required: true
+      GOOGLE_PLAY_SERVICE_ACCOUNT:
+        required: false
+      SLACK_WEBHOOK:
+        required: false
+      DISCORD_WEBHOOK:
+        required: false
+      GITHUB_TOKEN:
+        required: true
 
 env:
   EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
   EXPO_APPLE_ID: ${{ secrets.EXPO_APPLE_ID }}
   EXPO_APPLE_PASSWORD: ${{ secrets.EXPO_APPLE_PASSWORD }}
   EXPO_TEAM_ID: ${{ secrets.EXPO_TEAM_ID }}
-  # GOOGLE_PLAY_SERVICE_ACCOUNT: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT }}
   SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
-  # DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }}
   NODE_OPTIONS: --openssl-legacy-provider
 
 jobs:
-  check-skip:
-    runs-on: ubuntu-latest
-    if: "!contains(github.event.head_commit.message, '[skip ci]')"
-    steps:
-      - name: Skip CI check
-        run: echo "Proceeding with workflow"
-
-  test:
-    needs: check-skip
+  build-android:
+    if: (github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master')) || github.event_name == 'workflow_dispatch'
     runs-on: ubuntu-latest
     steps:
       - name: 🏗 Checkout repository
@@ -86,30 +77,66 @@ jobs:
             ${{ runner.os }}-yarn-
 
       - name: 📦 Install dependencies
-        run: yarn install
+        run: |
+          yarn install
+          yarn global add eas-cli@latest
 
-      - name: 🧹 Run ESLint
-        run: yarn lint
+      - name: 📱 Setup EAS build cache
+        uses: actions/cache@v3
+        with:
+          path: ~/.eas-build-local
+          key: ${{ runner.os }}-eas-build-local-${{ hashFiles('**/package.json') }}
+          restore-keys: |
+            ${{ runner.os }}-eas-build-local-
 
-      - name: 📢 Notify test results
-        if: always()
-        uses: rtCamp/action-slack-notify@v2
+      - name: 🔄 Verify EAS CLI installation
+        run: |
+          echo "EAS CLI version:"
+          eas --version
+
+      - name: 📋 Fix package.json main entry (Linux)
+        run: |
+          if ! command -v jq &> /dev/null; then
+            sudo apt-get update && sudo apt-get install -y jq
+          fi
+          cp package.json package.json.bak
+          jq '.main = "node_modules/expo/AppEntry.js"' package.json > package.json.tmp && mv package.json.tmp package.json
+          cat package.json | grep "main"
+
+      - name:  Build Development APK
+        if: github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'dev' || github.event_name == 'push' && (github.event.inputs.platform == 'all' || github.event.inputs.platform == 'android')
+        run: |
+          export NODE_OPTIONS="--openssl-legacy-provider --max_old_space_size=4096"
+          eas build --platform android --profile development --local --non-interactive --output=./app-dev.apk
         env:
-          SLACK_WEBHOOK: ${{ env.SLACK_WEBHOOK }}
-          SLACK_COLOR: ${{ job.status == 'success' && 'good' || 'danger' }}
-          SLACK_TITLE: Test Results
-          SLACK_MESSAGE: "Tests ${{ job.status == 'success' && 'passed ✅' || 'failed ❌' }}"
+          NODE_ENV: development
+
+      - name: 📱 Build Production AAB
+        if: github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'prod-aab' || github.event_name == 'push' && (github.event.inputs.platform == 'all' || github.event.inputs.platform == 'android')
+        run: |
+          export NODE_OPTIONS="--openssl-legacy-provider --max_old_space_size=4096"
+          eas build --platform android --profile production --local --non-interactive --output=./app-prod.aab
+        env:
+          NODE_ENV: production
 
-  build-and-release:
-    needs: test
+      - name: 🚀 Publish to Expo (optional)
+        if: github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'publish-expo'
+        run: |
+          eas update --auto
+
+      - name: 📦 Upload Android artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: android-builds
+          path: |
+            ./app-dev.apk
+            ./app-prod.aab
+          if-no-files-found: ignore
+          retention-days: 7
+
+  build-ios:
     if: (github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master')) || github.event_name == 'workflow_dispatch'
-    strategy:
-      matrix:
-        platform: [android]
-        include:
-          - platform: ios
-            runs-on: macos-latest
-    runs-on: ${{ matrix.platform == 'ios' && 'macos-latest' || 'ubuntu-latest' }}
+    runs-on: macos-latest
     steps:
       - name: 🏗 Checkout repository
         uses: actions/checkout@v4
@@ -150,124 +177,71 @@ jobs:
           echo "EAS CLI version:"
           eas --version
 
-      - name: 📋 Fix package.json main entry
+      - name: 📋 Fix package.json main entry (macOS)
         run: |
-          # Check if jq is installed, if not install it
           if ! command -v jq &> /dev/null; then
-            echo "Installing jq..."
-            sudo apt-get update && sudo apt-get install -y jq
+            brew update || true
+            brew install jq || true
           fi
+          cp package.json package.json.bak
+          jq '.main = "node_modules/expo/AppEntry.js"' package.json > package.json.tmp && mv package.json.tmp package.json
+          cat package.json | grep "main"
 
-          # Fix the main entry in package.json
-          if [ -f ./package.json ]; then
-            # Create a backup
-            cp package.json package.json.bak
-            # Update the package.json
-            jq '.main = "node_modules/expo/AppEntry.js"' package.json > package.json.tmp && mv package.json.tmp package.json
-            echo "Updated package.json main entry"
-            cat package.json | grep "main"
-          else
-            echo "package.json not found"
-            exit 1
-          fi
-
-      - name: 📋 Update metro.config.js for SVG support
-        run: |
-          if [ -f ./metro.config.js ]; then
-            echo "Creating backup of metro.config.js"
-            cp ./metro.config.js ./metro.config.js.backup
-            echo "Updating metro.config.js to CommonJS format"
-            cat > ./metro.config.js << 'EOFMARKER'
-          /* eslint-disable @typescript-eslint/no-var-requires */
-          const { getDefaultConfig } = require('expo/metro-config');
-
-          const config = getDefaultConfig(__dirname);
-
-          const { transformer, resolver } = config;
-
-          config.transformer = {
-            ...transformer,
-            babelTransformerPath: require.resolve('react-native-svg-transformer/expo'),
-          };
-
-          config.resolver = {
-            ...resolver,
-            assetExts: resolver.assetExts.filter(ext => ext !== 'svg'),
-            sourceExts: [...resolver.sourceExts, 'svg'],
-          };
-
-          module.exports = config;
-          EOFMARKER
-            echo "metro.config.js updated to CommonJS format"
-          else
-            echo "metro.config.js not found"
-          fi
-
-      - name: 📱 Build Development APK
-        if: github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'dev' || github.event_name == 'push' && (matrix.platform == 'android' || github.event.inputs.platform == 'all' || github.event.inputs.platform == 'android')
-        run: |
-          # Build with increased memory limit
-          export NODE_OPTIONS="--openssl-legacy-provider --max_old_space_size=4096"
-          eas build --platform android --profile development --local --non-interactive --output=./app-dev.apk
-        env:
-          NODE_ENV: development
-
-      - name: 📱 Build Production APK
-        if: github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'prod-apk' || github.event_name == 'push' && (matrix.platform == 'android' || github.event.inputs.platform == 'all' || github.event.inputs.platform == 'android')
-        run: |
-          export NODE_OPTIONS="--openssl-legacy-provider --max_old_space_size=4096"
-          eas build --platform android --profile production-apk --local --non-interactive --output=./app-prod.apk
-        env:
-          NODE_ENV: production
-
-      - name: 📱 Build Production AAB
-        if: github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'prod-aab' || github.event_name == 'push' && (matrix.platform == 'android' || github.event.inputs.platform == 'all' || github.event.inputs.platform == 'android')
-        run: |
-          export NODE_OPTIONS="--openssl-legacy-provider --max_old_space_size=4096"
-          eas build --platform android --profile production --local --non-interactive --output=./app-prod.aab
-        env:
-          NODE_ENV: production
 
       - name: 📱 Build iOS Development
-        if: (github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'ios-dev') && (matrix.platform == 'ios' || github.event.inputs.platform == 'all' || github.event.inputs.platform == 'ios')
+        if: (github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'ios-dev') && (github.event.inputs.platform == 'all' || github.event.inputs.platform == 'ios' || github.event_name == 'push')
         run: |
           export NODE_OPTIONS="--openssl-legacy-provider --max_old_space_size=4096"
           eas build --platform ios --profile development --local --non-interactive --output=./app-ios-dev.app
         env:
           NODE_ENV: development
 
       - name: 📱 Build iOS Production
-        if: (github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'ios-prod') && (matrix.platform == 'ios' || github.event.inputs.platform == 'all' || github.event.inputs.platform == 'ios')
+        if: (github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'ios-prod') && (github.event.inputs.platform == 'all' || github.event.inputs.platform == 'ios' || github.event_name == 'push')
         run: |
           export NODE_OPTIONS="--openssl-legacy-provider --max_old_space_size=4096"
           eas build --platform ios --profile production --local --non-interactive --output=./app-ios-prod.ipa
         env:
           NODE_ENV: production
 
-      - name: 🚀 Publish to Expo
-        if: github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'publish-expo'
+      - name: 📦 Zip iOS .app (development)
         run: |
-          eas update --auto
-        env:
-          EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
-
-      # - name: 🚀 Submit to Play Store
-      #   if: (github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'publish-stores') && (matrix.platform == 'android' || github.event.inputs.platform == 'all' || github.event.inputs.platform == 'android')
-      #   run: |
-      #     eas submit -p android --path ./app-prod.aab --non-interactive
-      #   env:
-      #     EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
-      #     GOOGLE_PLAY_SERVICE_ACCOUNT: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT }}
-
-      # - name: 🚀 Submit to App Store
-      #   if: (github.event.inputs.buildType == 'all' || github.event.inputs.buildType == 'publish-stores') && (matrix.platform == 'ios' || github.event.inputs.platform == 'all' || github.event.inputs.platform == 'ios')
-      #   run: |
-      #     eas submit -p ios --path ./app-ios-prod.ipa --non-interactive
-      #   env:
-      #     EXPO_TOKEN: ${{ secrets.EXPO_TOKEN }}
-      #     EXPO_APPLE_ID: ${{ secrets.EXPO_APPLE_ID }}
-      #     EXPO_APPLE_PASSWORD: ${{ secrets.EXPO_APPLE_PASSWORD }}
-      #     EXPO_TEAM_ID: ${{ secrets.EXPO_TEAM_ID }}
+          if [ -d "./app-ios-dev.app" ]; then
+            ditto -c -k --sequesterRsrc --keepParent "./app-ios-dev.app" "./app-ios-dev.zip"
+          fi
+
+      - name: 📦 Upload iOS artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: ios-builds
+          path: |
+            ./app-ios-dev.app
+            ./app-ios-dev.zip
+            ./app-ios-prod.ipa
+          if-no-files-found: ignore
+          retention-days: 7
+
+  create-release:
+    needs: [build-android, build-ios]
+    runs-on: ubuntu-latest
+    if: always()
+    steps:
+      - name: 🏗 Checkout repository
+        uses: actions/checkout@v4
+
+      - name: ⬇️ Download Android artifacts
+        if: ${{ needs.build-android.result == 'success' }}
+        uses: actions/download-artifact@v4
+        with:
+          name: android-builds
+          path: ./dist
+
+      - name: ⬇️ Download iOS artifacts
+        if: ${{ needs.build-ios.result == 'success' }}
+        uses: actions/download-artifact@v4
+        with:
+          name: ios-builds
+          path: ./dist
 
       - name: 🏷️ Generate build information
         id: build-info
@@ -276,46 +250,34 @@ jobs:
           BUILD_NUMBER=$(date +%Y%m%d%H%M)
           echo "version=$VERSION" >> $GITHUB_OUTPUT
           echo "build_number=$BUILD_NUMBER" >> $GITHUB_OUTPUT
-          # Generate changelog from commit messages since last tag
           if git describe --tags --abbrev=0 > /dev/null 2>&1; then
             LAST_TAG=$(git describe --tags --abbrev=0)
             git log $LAST_TAG..HEAD --pretty=format:"- %s" > changelog.md
           else
             git log --pretty=format:"- %s" -n 10 > changelog.md
           fi
 
-      - name: 📝 Create GitHub Release
-        uses: softprops/action-gh-release@v1
+      - name: 📝 Create or Update GitHub Release
+        uses: softprops/action-gh-release@v2
         with:
           draft: true
           name: "Release v${{ steps.build-info.outputs.version }}-${{ steps.build-info.outputs.build_number }}"
           tag_name: "v${{ steps.build-info.outputs.version }}-${{ steps.build-info.outputs.build_number }}"
           files: |
-            ./app-dev.apk
-            ./app-prod.apk
-            ./app-prod.aab
-            ./app-ios-dev.app
-            ./app-ios-prod.ipa
+            ./dist/app-dev.apk
+            ./dist/app-prod.aab
+            ./dist/app-ios-dev.zip
+            ./dist/app-ios-prod.ipa
+          fail_on_unmatched_files: false
           body_path: changelog.md
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - name: 📦 Upload build artifacts to GitHub
-        uses: actions/upload-artifact@v4
-        with:
-          name: app-builds
-          path: |
-            ./app-dev.apk
-            ./app-prod.apk
-            ./app-prod.aab
-            ./app-ios-dev.app
-            ./app-ios-prod.ipa
-          retention-days: 7
 
-      - name: 📢 Notify build completion
+      - name: 📢 Notify release status
         if: always()
         uses: rtCamp/action-slack-notify@v2
         env:
           SLACK_WEBHOOK: ${{ env.SLACK_WEBHOOK }}
           SLACK_COLOR: ${{ job.status == 'success' && 'good' || 'danger' }}
-          SLACK_TITLE: Build Results
-          SLACK_MESSAGE: "Build ${{ job.status == 'success' && 'completed successfully ✅' || 'failed ❌' }}"
+          SLACK_TITLE: Release Results
+          SLACK_MESSAGE: "Release ${{ job.status == 'success' && 'created/updated ✅' || 'failed ❌' }}"