Moving to version 0.0.28

Author: jgriss

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 0.0.28
+
+  * Added new function get_inverter_day_stats (by jgonzalezzitu)
+  * Extended get_battery_day_stats function to retrieve more data (by jgonzalezzitu)
+
 # 0.0.27
 
   * Added tests for README examples

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = fusion_solar_py
-version = 0.0.27
+version = 0.0.28
 author = Johannes Griss
 author_email = johannes.griss@meduniwien.ac.at
 description = A simply API to the Huawei Fusion Solar web interface.

src/fusion_solar_py/client.py

@@ -736,7 +736,7 @@ def get_battery_basic_stats(self, battery_id: str) -> BatteryStatus:
         return battery_status
 
     @logged_in
-    def get_battery_day_stats(self, battery_id: str, signalIds: [str] = ["30005", "30007"],query_time: int = None) -> dict:
+    def get_battery_day_stats(self, battery_id: str, signalIds: list[str] = ["30005", "30007"],query_time: int = None) -> dict:
         """Retrieves the SOC (state of charge) in % and charge/discharge power in kW of
         the battery for the current day.
         :param battery_id: The battery's id
@@ -784,8 +784,8 @@ def get_battery_day_stats(self, battery_id: str, signalIds: [str] = ["30005", "3
 
         return battery_data["data"]
 
-        @logged_in
-    def get_inverter_day_stats(self, inverter_id: str, signalIds: [str] = ["30007"],query_time: int = None) -> dict:
+    @logged_in
+    def get_inverter_day_stats(self, inverter_id: str, signalIds: list[str] = ["30007"],query_time: int = None) -> dict:
         """Retrieves data of
         the inverter for the current day (or another day).
         :param inverter_id: The inverter's id
@@ -809,9 +809,12 @@ def get_inverter_day_stats(self, inverter_id: str, signalIds: [str] = ["30007"],
         :type signalIds: [str]
         :return: The complete data structure as a dict
         """
-        current_time = round(time.time() * 1000)
+        # either use the user supplied time or the current one
         if query_time is not None:
             current_time = query_time
+        else:
+            current_time = round(time.time() * 1000)
+
         r = self._session.get(
             url=f"https://{self._huawei_subdomain}.fusionsolar.huawei.com/rest/pvms/web/device/v1/device-history-data",
             params={
@@ -821,16 +824,16 @@ def get_inverter_day_stats(self, inverter_id: str, signalIds: [str] = ["30007"],
                 "_": current_time,
             },
         )
+
         r.raise_for_status()
-        battery_data = r.json()
+        inverter_data = r.json()
 
-        if not battery_data["success"] or "data" not in battery_data:
+        if not inverter_data["success"] or "data" not in inverter_data:
             raise FusionSolarException(
                 f"Failed to retrieve battery day stats for {inverter_id}"
             )
 
-
-        return battery_data["data"]
+        return inverter_data["data"]
 
 
     @logged_in