Skip to content

Commit 0f86b1c

Browse files
committed
remove encrypted-secrets example
The machinehub mode is required for key fetching, but doesn't play nicely with one shot mode and the example hangs. Secret encryption is covered in the e2e tests, so just remove the example for simplicity Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
1 parent 0dbdebb commit 0f86b1c

4 files changed

Lines changed: 6 additions & 159 deletions

File tree

examples/encrypted-secrets/README.md

Lines changed: 0 additions & 47 deletions
This file was deleted.

examples/encrypted-secrets/config.yaml

Lines changed: 0 additions & 41 deletions
This file was deleted.

examples/encrypted-secrets/test.sh

Lines changed: 0 additions & 65 deletions
This file was deleted.

internal/envelope/keyfetch/fake_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ func TestFakeClient(t *testing.T) {
1515
t.Run("returns generated key by default", func(t *testing.T) {
1616
fake := NewFakeClient()
1717

18-
key, err := fake.FetchKey(context.Background())
18+
key, err := fake.FetchKey(t.Context())
1919
require.NoError(t, err)
2020

2121
assert.Equal(t, "test-key", key.KeyID)
2222
assert.NotNil(t, key.Key)
2323
assert.Equal(t, 1, fake.FetchKeyCalls)
2424

2525
// Subsequent calls return the same key
26-
key2, err := fake.FetchKey(context.Background())
26+
key2, err := fake.FetchKey(t.Context())
2727
require.NoError(t, err)
2828
assert.Equal(t, key.KeyID, key2.KeyID)
2929
assert.Equal(t, key.Key, key2.Key)
@@ -36,7 +36,7 @@ func TestFakeClient(t *testing.T) {
3636

3737
fake := NewFakeClientWithKey("custom-key", &privateKey.PublicKey)
3838

39-
key, err := fake.FetchKey(context.Background())
39+
key, err := fake.FetchKey(t.Context())
4040
require.NoError(t, err)
4141

4242
assert.Equal(t, "custom-key", key.KeyID)
@@ -48,7 +48,7 @@ func TestFakeClient(t *testing.T) {
4848
expectedErr := errors.New("test error")
4949
fake := NewFakeClientWithError(expectedErr)
5050

51-
_, err := fake.FetchKey(context.Background())
51+
_, err := fake.FetchKey(t.Context())
5252
require.Error(t, err)
5353

5454
assert.Equal(t, expectedErr, err)
@@ -58,7 +58,7 @@ func TestFakeClient(t *testing.T) {
5858
t.Run("respects context cancellation", func(t *testing.T) {
5959
fake := NewFakeClient()
6060

61-
ctx, cancel := context.WithCancel(context.Background())
61+
ctx, cancel := context.WithCancel(t.Context())
6262
cancel()
6363

6464
_, err := fake.FetchKey(ctx)
@@ -81,7 +81,7 @@ func TestFakeClient(t *testing.T) {
8181
Err: expectedErr,
8282
}
8383

84-
_, err = fake.FetchKey(context.Background())
84+
_, err = fake.FetchKey(t.Context())
8585
require.Error(t, err)
8686

8787
assert.Equal(t, expectedErr, err)

0 commit comments

Comments
 (0)