fix: suppress "View not found" alert and update pane index on group removal#139
Merged
Conversation
…emoval - Guard removeGroup call with existence check to prevent double-removal race condition when TerminalKillFocusRestoreController and VSCode's built-in closeEmptyGroups both try to remove the same group - Add onDidAddGroup/onDidRemoveGroup events to IEditorGroupsView interface so MultiEditorTabsControl can update the [N] pane index badge when groups are added or removed - Add Event.None stubs to TestEditorGroupAccessor for new interface events Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeGroupcall withgetGroupexistence check indoCloseActiveEditorto prevent double-removal race condition whenTerminalKillFocusRestoreControllerand VSCode's built-incloseEmptyGroupsboth try to remove the same grouponDidAddGroup/onDidRemoveGroupevents toIEditorGroupsViewinterface soMultiEditorTabsControlcan update the[N]pane index badge when groups are added or removedEvent.Nonestubs toTestEditorGroupAccessorfor new interface eventsCloses #22
Test plan
[N]badges update correctlycoderm.terminal.closeEmptyPaneOnKill: true+closeEditorsInGroupcommand — no error alert🤖 Generated with Claude Code