kubo 0.35.0-rc1: missing Provide.Enabled flag

[lidel]

Checklist

• This is a bug report, not a question. Ask questions on discuss.ipfs.tech.
• I have searched on the issue tracker for my bug.
• I am running the latest kubo version or have an issue updating.

Installation method

dist.ipfs.tech or ipfs-update

Version

0.35.0-rc1

Config

default

Description

Kubo has ability to disable DHT announcements by setting Reprovider.Interval to 0.

(Un)fortunately 0.35.0-rc1 (#10760) included ipfs/boxo#907 which introduced separate queue for initial provides, which does not seem to be covered by this setting, which makes it impossible to disable DHT announcements of newly added data.

Proposed fix

• Introduce explicit Provider.Enabled (type Flag, true by default) for controlling initial provides
  • ❓ OR should it be Provider.Strategy as OptionalString and two options all|off with all being default (allowing us to have more in future?)
  • Keep it a bool for clarity.
• To keep things simple, disable both systems if either Reprovider.Interval=0 or Provider.Enabled=false + log a message informing user that provides are disabled as well, to remove any surprises.
  • We can do deeper refactor later, to allow disabling each one separately.

[guillaumemichel]

The strategic provide option is already disabling DHT provides.

kubo/core/node/provider.go

Lines 135 to 138 in 6f37df7

	func OnlineProviders(useStrategicProviding bool, reprovideStrategy string, reprovideInterval time.Duration, acceleratedDHTClient bool, provideWorkerCount int) fx.Option {
	if useStrategicProviding {
	return OfflineProviders()
	}

It seems that providing nothing is a side effect/temporary. If we want to implement a dedicated Provide.Enabled flag, it can do exactly like the strategic provide is currently doing (using noop provider).

[lidel]

• Done: fix(config): wire up Provider.Enabled flag #10804