Lint

Sync with Microsoft ONNX Runtime - 18032026 #1856

Sign in to view logs

Triggered via pull request March 17, 2026 21:00

Jaswanth51

opened #980

sync_msft_18032026

Status Cancelled

Total duration 1d 0h 0m 2s

Artifacts –

lint.yml

on: pull_request

Optional Lint C++

Annotations

1 error, 6 warnings, and 39 notices

Python format

The job has exceeded the maximum execution time while awaiting a runner for 24h0m0s

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L7 <ShellCheck.SC2220>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L7

Invalid flags are not handled. Add a *) case.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L80 <ShellCheck.SC2046>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L80

Quote this to prevent word splitting.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L105 <ShellCheck.SC2046>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L105

Quote this to prevent word splitting.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L7 <ShellCheck.SC2220>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L7

Invalid flags are not handled. Add a *) case.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L80 <ShellCheck.SC2046>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L80

Quote this to prevent word splitting.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L105 <ShellCheck.SC2046>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L105

Quote this to prevent word splitting.

[misspell] onnxruntime/core/optimizer/qdq_transformer/selectors_actions/qdq_actions.cc#L167: onnxruntime/core/optimizer/qdq_transformer/selectors_actions/qdq_actions.cc#L167

"NTO" is a misspelling of "NOT"

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L64 <ShellCheck.SC2001>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L64

See if you can use ${variable//search/replace} instead.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L64 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L64

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L65 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L65

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L70 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L70

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L72 <ShellCheck.SC2035>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L72

Use ./*glob* or -- *glob* so names with dashes won't become options.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L75 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L75

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L87 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L87

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L89 <ShellCheck.SC2001>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L89

See if you can use ${variable//search/replace} instead.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L95 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L95

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L100 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/inference/aarch64/python/cpu/scripts/install_protobuf.sh#L100

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L64 <ShellCheck.SC2001>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L64

See if you can use ${variable//search/replace} instead.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L64 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L64

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L65 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L65

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L70 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L70

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L72 <ShellCheck.SC2035>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L72

Use ./*glob* or -- *glob* so names with dashes won't become options.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L75 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L75

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L87 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L87

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L89 <ShellCheck.SC2001>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L89

See if you can use ${variable//search/replace} instead.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L95 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L95

Double quote to prevent globbing and word splitting.

[shellcheck] tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L100 <ShellCheck.SC2086>: tools/ci_build/github/linux/docker/scripts/install_protobuf.sh#L100

Double quote to prevent globbing and word splitting.

[cpplint] include/onnxruntime/core/common/logging/logging.h#L61: include/onnxruntime/core/common/logging/logging.h#L61

Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

[cpplint] include/onnxruntime/core/common/logging/logging.h#L70: include/onnxruntime/core/common/logging/logging.h#L70

Single-parameter constructors should be marked explicit. [runtime/explicit] [4]

[cpplint] onnxruntime/contrib_ops/cpu/bert/attention_base.h#L352: onnxruntime/contrib_ops/cpu/bert/attention_base.h#L352

Using C-style cast. Use static_cast<int>(...) instead [readability/casting] [4]

[cpplint] onnxruntime/contrib_ops/cpu/bert/longformer_attention_base.h#L26: onnxruntime/contrib_ops/cpu/bert/longformer_attention_base.h#L26

Single-parameter constructors should be marked explicit. [runtime/explicit] [4]

[cpplint] onnxruntime/contrib_ops/cpu/crop.h#L19: onnxruntime/contrib_ops/cpu/crop.h#L19

Single-parameter constructors should be marked explicit. [runtime/explicit] [4]

[cpplint] onnxruntime/contrib_ops/cuda/bert/attention_kv_cache.cu#L8: onnxruntime/contrib_ops/cuda/bert/attention_kv_cache.cu#L8

Found C system header after other header. Should be: attention_kv_cache.h, c system, c++ system, other. [build/include_order] [4]

[cpplint] onnxruntime/contrib_ops/cuda/llm/cutlass_heuristic.cc#L31: onnxruntime/contrib_ops/cuda/llm/cutlass_heuristic.cc#L31

Include the directory when naming header files [build/include_subdir] [4]

[cpplint] onnxruntime/core/platform/linux/device_discovery.cc#L228: onnxruntime/core/platform/linux/device_discovery.cc#L228

Add #include <string> for string [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/platform/linux/pci_device_discovery.h#L8: onnxruntime/core/platform/linux/pci_device_discovery.h#L8

<filesystem> is an unapproved C++17 header. [build/c++17] [5]

[cpplint] onnxruntime/core/providers/cuda/llm/tensorscatter_impl.cu#L41: onnxruntime/core/providers/cuda/llm/tensorscatter_impl.cu#L41

Add #include <algorithm> for min [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/cuda/tensor/grid_sample.cc#L69: onnxruntime/core/providers/cuda/tensor/grid_sample.cc#L69

Add #include <string> for string [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/cuda/tensor/grid_sample_impl.cu#L282: onnxruntime/core/providers/cuda/tensor/grid_sample_impl.cu#L282

Add #include <algorithm> for min [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc#L32: onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc#L32

Include the directory when naming header files [build/include_subdir] [4]

[cpplint] onnxruntime/core/providers/nv_tensorrt_rtx/nv_scoped_context.h#L5: onnxruntime/core/providers/nv_tensorrt_rtx/nv_scoped_context.h#L5

Include the directory when naming header files [build/include_subdir] [4]

[cpplint] onnxruntime/core/providers/nv_tensorrt_rtx/onnx_ctx_model_helper.h#L25: onnxruntime/core/providers/nv_tensorrt_rtx/onnx_ctx_model_helper.h#L25

For a static/global string constant, use a C style string instead: "static const char SOURCE[]". [runtime/string] [4]

[cpplint] onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L20: onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h#L20

For a static/global string constant, use a C style string instead: "static const char SOURCE[]". [runtime/string] [4]

[cpplint] onnxruntime/core/providers/webgpu/webgpu_context.cc#L993: onnxruntime/core/providers/webgpu/webgpu_context.cc#L993

Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]

[cpplint] onnxruntime/core/session/inference_session.cc#L117: onnxruntime/core/session/inference_session.cc#L117

Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]