From a0bad57e31113197e5f53e34bbf52f4f94241278 Mon Sep 17 00:00:00 2001 From: Rene Fernandez Date: Thu, 22 May 2025 15:15:26 +0200 Subject: [PATCH 1/2] Handle empty user and participant names Set default name for participants with no name in migration --- newdle/migrations/alembic.ini | 2 +- ...7_cab5d47c1152_ensure_participant_names.py | 28 +++++++++++++++++++ newdle/schemas.py | 5 ++++ 3 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 newdle/migrations/versions/20250704_1127_cab5d47c1152_ensure_participant_names.py diff --git a/newdle/migrations/alembic.ini b/newdle/migrations/alembic.ini index e0be03866..2c03477b2 100644 --- a/newdle/migrations/alembic.ini +++ b/newdle/migrations/alembic.ini @@ -1,6 +1,6 @@ [alembic] file_template = %%(year)d%%(month).2d%%(day).2d_%%(hour).2d%%(minute).2d_%%(rev)s_%%(slug)s - +script_location = newdle/migrations # Logging configuration [loggers] keys = root,sqlalchemy,alembic diff --git a/newdle/migrations/versions/20250704_1127_cab5d47c1152_ensure_participant_names.py b/newdle/migrations/versions/20250704_1127_cab5d47c1152_ensure_participant_names.py new file mode 100644 index 000000000..2a4eb7f1d --- /dev/null +++ b/newdle/migrations/versions/20250704_1127_cab5d47c1152_ensure_participant_names.py @@ -0,0 +1,28 @@ +"""Ensure participant names + +Revision ID: cab5d47c1152 +Revises: 30b5fe7b5949 +Create Date: 2025-07-04 11:27:08.792500 +""" + +from alembic import op + +# revision identifiers, used by Alembic. +revision = 'cab5d47c1152' +down_revision = '30b5fe7b5949' +branch_labels = None +depends_on = None + + +def upgrade(): + op.execute( + """ + UPDATE participants + SET name = '?' + WHERE name= ''; + """ + ) + + +def downgrade(): + pass diff --git a/newdle/schemas.py b/newdle/schemas.py index 6b9f4a0e0..917ae75bf 100644 --- a/newdle/schemas.py +++ b/newdle/schemas.py @@ -131,6 +131,11 @@ class ParticipantSchema(mm.Schema): ) ) + @validates('name') + def name_not_empty(self, value): + if not value: + raise ValidationError('This field cannot be empty.') + class RestrictedParticipantSchema(ParticipantSchema): class Meta: From 28b80bb54a1ec1e52bec66a718140f4537988e55 Mon Sep 17 00:00:00 2001 From: Adrian Date: Fri, 4 Jul 2025 12:29:01 +0200 Subject: [PATCH 2/2] Update newdle/migrations/alembic.ini --- newdle/migrations/alembic.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/newdle/migrations/alembic.ini b/newdle/migrations/alembic.ini index 2c03477b2..32eab5af3 100644 --- a/newdle/migrations/alembic.ini +++ b/newdle/migrations/alembic.ini @@ -1,6 +1,7 @@ [alembic] file_template = %%(year)d%%(month).2d%%(day).2d_%%(hour).2d%%(minute).2d_%%(rev)s_%%(slug)s script_location = newdle/migrations + # Logging configuration [loggers] keys = root,sqlalchemy,alembic