cmd/agentcli: port core CLI tests from develop; fix duration precedence (#82)

Ports focused develop tests (help/flags/docs-sync/gpt5 smoke) to validate CLI behavior on main.
Align ResolveDuration to treat flag-set zero as explicit, matching develop tests.

Refs: #1

Co-authored-by: aibuddy <aibuddy@dev.hg.fi>

Author: heusalagroupbot

cmd/agentcli/cli_docs_sync_test.go

@@ -0,0 +1,86 @@
+package main
+
+import (
+	"os"
+	"path/filepath"
+	"runtime"
+	"strings"
+	"testing"
+)
+
+// TestCLIReference_IncludesAllFlagsFromHelp ensures that docs/reference/cli-reference.md
+// includes every flag token that appears in the CLI's built-in help output.
+func TestCLIReference_IncludesAllFlagsFromHelp(t *testing.T) {
+	// Render help text via the same function used by the CLI for --help/-h/help.
+	var b strings.Builder
+	printUsage(&b)
+	help := b.String()
+
+	// Extract flag tokens from help output. Lines start with two spaces, a hyphen, then the flag.
+	var flags []string
+	for _, line := range strings.Split(help, "\n") {
+		line = strings.TrimRight(line, "\r")
+		if strings.HasPrefix(line, "  -") || strings.HasPrefix(line, "  --") {
+			// Take the first whitespace-separated token as the flag token (e.g., -prompt, --version)
+			fields := strings.Fields(line)
+			if len(fields) > 0 {
+				token := fields[0]
+				// Normalize trailing punctuation if any
+				token = strings.TrimRight(token, ":")
+				flags = append(flags, token)
+			}
+		}
+	}
+	if len(flags) == 0 {
+		t.Fatalf("no flags parsed from help; help was:\n%s", help)
+	}
+
+	// Load CLI reference doc. Resolve relative to this test file's directory for robustness.
+	_, thisFile, _, ok := runtime.Caller(0)
+	if !ok {
+		t.Fatalf("runtime.Caller failed")
+	}
+	thisDir := filepath.Dir(thisFile)
+	// Repo root is the parent of the parent (.. of cmd/agentcli => repo root)
+	repoRoot := filepath.Dir(filepath.Dir(thisDir))
+	tryPaths := []string{
+		filepath.Join(repoRoot, "docs", "reference", "cli-reference.md"),
+		filepath.Join(repoRoot, "README.md"), // fallback so test gives a clearer error if mislocated
+	}
+	var data []byte
+	var err error
+	var usedPath string
+	for _, p := range tryPaths {
+		if b, e := os.ReadFile(p); e == nil {
+			data, err, usedPath = b, nil, p
+			break
+		} else {
+			err = e
+		}
+	}
+	if data == nil {
+		t.Fatalf("failed to read CLI reference doc from %v: last error: %v", tryPaths, err)
+	}
+	_ = usedPath // retained for potential future diagnostics
+
+	doc := string(data)
+
+	// For each flag token from help, assert that the doc mentions it.
+	// We look for the raw token (e.g., "-prompt") to keep this simple and robust to formatting.
+	for _, token := range flags {
+		// The version line in help is "--version | -version". Ensure both variants are present in docs.
+		if token == "--version" {
+			if !strings.Contains(doc, "--version") || !strings.Contains(doc, "-version") {
+				t.Fatalf("docs missing one of version tokens: --version or -version; flags=%v", flags)
+			}
+			continue
+		}
+		// Skip duplicate check for -version since it is covered by the --version case.
+		if token == "-version" {
+			continue
+		}
+		if !strings.Contains(doc, token) {
+			t.Fatalf("docs/reference/cli-reference.md missing flag token %q from help; help line present, doc needs update", token)
+		}
+	}
+}

cmd/agentcli/compat_test.go

@@ -0,0 +1,93 @@
+package main
+
+import (
+	"bytes"
+	"encoding/json"
+	"os"
+	"strings"
+	"testing"
+)
+
+// TestLegacyPrintConfigDefaults_NoNewFlags ensures that a minimal invocation
+// without new flags produces the same resolved config baseline.
+func TestLegacyPrintConfigDefaults_NoNewFlags(t *testing.T) {
+	// Ensure env does not influence defaults
+	t.Setenv("OAI_BASE_URL", "")
+	t.Setenv("OAI_MODEL", "")
+	t.Setenv("OAI_HTTP_TIMEOUT", "")
+	t.Setenv("OAI_IMAGE_MODEL", "")
+
+	var out, err bytes.Buffer
+	code := cliMain([]string{"-prompt", "p", "-print-config"}, &out, &err)
+	if code != 0 {
+		t.Fatalf("print-config exit=%d, stderr=%s", code, err.String())
+	}
+	// Parse JSON
+	var payload map[string]any
+	if jerr := json.Unmarshal(out.Bytes(), &payload); jerr != nil {
+		t.Fatalf("unmarshal print-config: %v; got %s", jerr, out.String())
+	}
+	// Top-level expectations
+	if got, ok := payload["model"].(string); !ok || got != "oss-gpt-20b" {
+		t.Fatalf("model=%v; want oss-gpt-20b", payload["model"])
+	}
+	if got, ok := payload["baseURL"].(string); !ok || got != "https://api.openai.com/v1" {
+		t.Fatalf("baseURL=%v; want https://api.openai.com/v1", payload["baseURL"])
+	}
+	if got, ok := payload["httpTimeout"].(string); !ok || got != "30s" {
+		t.Fatalf("httpTimeout=%v; want 30s", payload["httpTimeout"])
+	}
+	// Image block expectations
+	img, ok := payload["image"].(map[string]any)
+	if !ok {
+		t.Fatalf("missing image block in print-config")
+	}
+	if got, ok := img["model"].(string); !ok || got != "gpt-image-1" {
+		t.Fatalf("image.model=%v; want gpt-image-1", img["model"])
+	}
+}
+
+func TestConflictingPromptSources_ErrorMessage(t *testing.T) {
+	var out, err bytes.Buffer
+	code := cliMain([]string{"-prompt", "p", "-prompt-file", os.DevNull}, &out, &err)
+	if code != 2 {
+		t.Fatalf("exit=%d; want 2", code)
+	}
+	if !strings.Contains(err.String(), "-prompt and -prompt-file are mutually exclusive") {
+		t.Fatalf("stderr did not contain conflict message; got: %s", err.String())
+	}
+}
+
+func TestConflictingSystemSources_ErrorMessage(t *testing.T) {
+	var out, err bytes.Buffer
+	// Provide both -system (non-default) and -system-file
+	code := cliMain([]string{"-prompt", "p", "-system", "X", "-system-file", os.DevNull}, &out, &err)
+	if code != 2 {
+		t.Fatalf("exit=%d; want 2", code)
+	}
+	if !strings.Contains(err.String(), "-system and -system-file are mutually exclusive") {
+		t.Fatalf("stderr did not contain system conflict message; got: %s", err.String())
+	}
+}
+
+func TestLoadMessagesWithPromptConflict_ErrorMessage(t *testing.T) {
+	var out, err bytes.Buffer
+	code := cliMain([]string{"-load-messages", os.DevNull, "-prompt", "p"}, &out, &err)
+	if code != 2 {
+		t.Fatalf("exit=%d; want 2", code)
+	}
+	if !strings.Contains(err.String(), "-load-messages cannot be combined with -prompt or -prompt-file") {
+		t.Fatalf("stderr did not contain load/prompt conflict message; got: %s", err.String())
+	}
+}
+
+func TestSaveAndLoadMessagesConflict_ErrorMessage(t *testing.T) {
+	var out, err bytes.Buffer
+	code := cliMain([]string{"-prompt", "p", "-save-messages", os.DevNull, "-load-messages", os.DevNull}, &out, &err)
+	if code != 2 {
+		t.Fatalf("exit=%d; want 2", code)
+	}
+	if !strings.Contains(err.String(), "-save-messages and -load-messages are mutually exclusive") {
+		t.Fatalf("stderr did not contain save/load conflict message; got: %s", err.String())
+	}
+}