Skip to content

Intro page with image#6

Open
lucfr wants to merge 1 commit into
mainfrom
intro-page
Open

Intro page with image#6
lucfr wants to merge 1 commit into
mainfrom
intro-page

Conversation

@lucfr
Copy link
Copy Markdown
Member

@lucfr lucfr commented Aug 5, 2022

Added an intro page at the top similar to the other topics. Contains a temporary header image to get look and feel.

@lucfr lucfr requested a review from mmaelicke August 5, 2022 10:58
@lucfr lucfr added the enhancement New feature or request label Aug 5, 2022
Copy link
Copy Markdown
Member

@mmaelicke mmaelicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you commited all changes, because for me, this PR adds an empty topic to the top of the site...

@lucfr
Copy link
Copy Markdown
Member Author

lucfr commented Aug 5, 2022

The problem is that I can't verify my changes due to a compile error with webpack. I tried to recreate a topic page like the others with a short title, text and image. See intro.tsx and the supporting changes in the other files.

@mmaelicke
Copy link
Copy Markdown
Member

Alright, I will have a look at it and try to fix it.

@mmaelicke mmaelicke self-assigned this Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants