From 90a5e3b648e5438ef7c8e055a81fcabb5837e74e Mon Sep 17 00:00:00 2001
From: Mike Little <mike@zed1.com>
Date: Tue, 19 May 2026 17:54:50 +0100
Subject: [PATCH] Fix module-ci artifact name and add module-config input
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Two fixes to module-ci.yml that surfaced when altis-media's first GHA
run failed Codeception:

1. Artifact upload now sanitises '/' out of the composer package name.
   The previous template produced names like 'codecept-output-altis/media-php8.3',
   which actions/upload-artifact@v4 rejects (forward slashes are not allowed
   in artifact names). The step is `if: failure()`, so the bug only
   surfaced when Codeception itself failed.

2. New optional `module-config` input lets a caller pass a JSON snippet
   that is deep-merged into `extra.altis.modules` in the test-root
   composer.json. Used to enable opt-in module features for the CI run
   without per-test runtime injection — e.g. altis-media will pass
   `{"media":{"private-media":true}}` so its acceptance tests can find
   the private-media UI affordances.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .github/workflows/module-ci.yml | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/module-ci.yml b/.github/workflows/module-ci.yml
index e3d6ac5..c51e893 100644
--- a/.github/workflows/module-ci.yml
+++ b/.github/workflows/module-ci.yml
@@ -31,6 +31,10 @@ on:
         description: 'Runner image. Defaults to ubuntu-22.04 to match the previous Travis "jammy" dist.'
         default: 'ubuntu-22.04'
         type: string
+      module-config:
+        description: 'Optional JSON object merged into extra.altis.modules in the test-root composer.json. Used to enable opt-in module features for the CI run, e.g. ''{"media":{"private-media":true}}''.'
+        default: ''
+        type: string
     secrets:
       DOCKER_USERNAME:
         required: true
@@ -110,6 +114,7 @@ jobs:
       - name: Install test theme and inject package under test
         env:
           BASE_BRANCH: ${{ steps.base.outputs.base-branch }}
+          MODULE_CONFIG: ${{ inputs.module-config }}
         shell: bash
         run: |
           set -euo pipefail
@@ -122,6 +127,14 @@ jobs:
           jq '. * {"extra":{"altis":{"modules":{"cms":{"default-theme":"test-theme"},"dev-tools":{"codeception":{"modules":{"config":{"WPLoader":{"theme":"test-theme"}}}}}}}}}' composer.json > composer.json.tmp
           mv composer.json.tmp composer.json
 
+          # Merge any caller-provided module config into extra.altis.modules.
+          if [[ -n "$MODULE_CONFIG" ]]; then
+            jq --argjson cfg "$MODULE_CONFIG" \
+              '. * {"extra":{"altis":{"modules":$cfg}}}' \
+              composer.json > composer.json.tmp
+            mv composer.json.tmp composer.json
+          fi
+
           # Use GitHub as the source for test to avoid packagist lag causing a race condition
           composer config "repositories.$ALTIS_PACKAGE" vcs "https://github.com/humanmade/altis-${ALTIS_PACKAGE#altis/}.git"
 
@@ -200,11 +213,19 @@ jobs:
           cd "$HOME/test-root"
           composer dev-tools lintdocs -l "vendor/${ALTIS_PACKAGE}" all
 
+      - name: Compute artifact name
+        if: failure()
+        id: artifact
+        shell: bash
+        run: |
+          # Artifact names disallow '/', so substitute the composer-name slash with '-'.
+          echo "name=codecept-output-${ALTIS_PACKAGE//\//-}-php${{ inputs.php-version }}" >> "$GITHUB_OUTPUT"
+
       - name: Upload Codeception output on failure
         if: failure()
         uses: actions/upload-artifact@v4
         with:
-          name: codecept-output-${{ inputs.altis-package }}-php${{ inputs.php-version }}
+          name: ${{ steps.artifact.outputs.name }}
           path: |
             ~/test-root/.tests/_output/
             ~/test-root/tests/_output/