Skip to content

Commit fb61cbf

Browse files
Nicholas J. Kisseberthclaude
andcommitted
Fix count() warnings in recommendation plugins
Use count() instead of truthy check on results collections to avoid PHP warnings when collection objects evaluate differently than arrays. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent ebf65cd commit fb61cbf

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

core/plugins/publications/recommendations/views/browse/tmpl/default.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<p><?php echo Lang::txt('PLG_PUBLICATION_RECOMMENDATIONS_EXPLANATION'); ?></p>
1919
</div>
2020
<div class="subject" id="recommendations-subject">
21-
<?php if ($this->results) { ?>
21+
<?php if (count($this->results)) { ?>
2222
<ul>
2323
<?php
2424
foreach ($this->results as $line)

core/plugins/publications/recommendations/views/browse/tmpl/mini.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
?>
1313
<div id="recommendations">
1414
<h3><?php echo Lang::txt('PLG_PUBLICATION_RECOMMENDATIONS_HEADER'); ?></h3>
15-
<?php if ($this->results) { ?>
15+
<?php if (count($this->results)) { ?>
1616
<ul>
1717
<?php
1818
foreach ($this->results as $line)

core/plugins/resources/recommendations/views/browse/tmpl/default.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<div id="recommendations">
1414
<h3><?php echo Lang::txt('PLG_RESOURCES_RECOMMENDATIONS_HEADER'); ?></h3>
1515
<div class="subject" id="recommendations-subject" data-base="<?php echo Request::base(true); ?>">
16-
<?php if ($this->results) { ?>
16+
<?php if (count($this->results)) { ?>
1717
<ul>
1818
<?php foreach ($this->results as $line) { ?>
1919
<li>

core/plugins/resources/recommendations/views/browse/tmpl/mini.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<div class="container" id="recommendations">
1212
<h3><?php echo Lang::txt('PLG_RESOURCES_RECOMMENDATIONS_HEADER'); ?></h3>
1313

14-
<?php if ($this->results) { ?>
14+
<?php if (count($this->results)) { ?>
1515
<ul>
1616
<?php foreach ($this->results as $line) { ?>
1717
<li>

0 commit comments

Comments
 (0)