Skip to content

Ask parent project to run a goal if pasbuild is run in a sub module, but only if version is empty. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewd207 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ask parent project to run a goal if pasbuild is run in a sub module, but only if version is empty. #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fe15a6
ask parent project to run a goal if pasbuild is run on a module of a …
andrewd207 May 15, 2026
464de82
and run the original error
andrewd207 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion src/main/pascal/PasBuild.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@
PluginPath: string;
PhaseInfo: TPluginPhaseInfo;
CompilerPath: string;
ParentXml: string;
ParentConfig: TProjectConfig;
IsParentPom: Boolean;
ModuleName: string;

begin
// Parse command line arguments
Expand Down Expand Up @@ -148,7 +152,7 @@
else
begin
try
Config := TConfigLoader.LoadProjectXML(Args.ProjectFile);
Config := TConfigLoader.LoadProjectXML(Args.ProjectFile, True);
except
on E: EProjectConfigError do
begin
Expand All @@ -163,6 +167,46 @@
Exit;
end;
end;

// When a module omits <version> (inheriting from aggregator) and the user
// ran pasbuild from that module's directory, automatically redirect to the
// parent aggregator and build only this module.
if (Config.Version = '') and (Args.SelectedModule = '') then
begin
ParentXml := ExpandFileName('../project.xml');
if FileExists(ParentXml) then
begin
ParentConfig := nil;
IsParentPom := False;
try
ParentConfig := TConfigLoader.LoadProjectXML(ParentXml, True);
IsParentPom := ParentConfig.BuildConfig.ProjectType = ptPom;
except
// Ignore load errors; fall through to normal validation (which will
// report the missing <version> on the current project).
end;
if IsParentPom then
begin
ModuleName := Config.Name;
Config.Free;
Config := ParentConfig;
ParentConfig := nil;
TUtils.LogInfo('No <version> found; delegating to aggregator for module "' + ModuleName + '"');
SetCurrentDir(ExpandFileName('..'));
Args.ProjectFile := 'project.xml';
Args.SelectedModule := ModuleName;
end
else
ParentConfig.Free;
end;
// If still no version after the parent-POM check, restore the original error.
if Config.Version = '' then
begin
TUtils.LogError('Missing required field: <version>');
ExitCode := 1;
Exit;
end;
end;
end;

try
Expand Down